Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-10 Thread Anand Moon
Hi Vivek, On 10 October 2017 at 11:57, Vivek Gautam wrote: > > > On 10/08/2017 06:06 PM, Anand Moon wrote: >> >> Hi Krzysztof, >> >> On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: >>> >>> On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: update the usbdrd link control and phy

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-09 Thread Vivek Gautam
On 10/08/2017 06:06 PM, Anand Moon wrote: Hi Krzysztof, On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: update the usbdrd link control and phy contol clks. The commit title and especially commit message should explain why you are do

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-09 Thread Krzysztof Kozlowski
On Mon, Oct 09, 2017 at 02:36:13AM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 8 October 2017 at 21:17, Krzysztof Kozlowski wrote: > > On Sun, Oct 08, 2017 at 06:06:19PM +0530, Anand Moon wrote: > >> Hi Krzysztof, > >> > >> On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: > >> > On Fri

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-08 Thread Anand Moon
Hi Krzysztof, On 8 October 2017 at 21:17, Krzysztof Kozlowski wrote: > On Sun, Oct 08, 2017 at 06:06:19PM +0530, Anand Moon wrote: >> Hi Krzysztof, >> >> On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: >> > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: >> >> update the usbdrd link co

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-08 Thread Krzysztof Kozlowski
On Sun, Oct 08, 2017 at 06:06:19PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: > > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: > >> update the usbdrd link control and phy contol clks. > > > > The commit title and especially commit mes

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-08 Thread Anand Moon
Hi Krzysztof, On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: > On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: >> update the usbdrd link control and phy contol clks. > > The commit title and especially commit message should explain why you > are doing this and what are you doing. "Upda

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-05 Thread Krzysztof Kozlowski
On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: > update the usbdrd link control and phy contol clks. The commit title and especially commit message should explain why you are doing this and what are you doing. "Update" is not enough. Everything could be called update. Therefore I do not under

[RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-05 Thread Anand Moon
update the usbdrd link control and phy contol clks. Signed-off-by: Anand Moon --- Tested on Odroid XU4 and Odroid HC1 develpment board. Did not test Odroid XU develpment board. --- arch/arm/boot/dts/exynos5410.dtsi | 4 ++-- arch/arm/boot/dts/exynos5420.dtsi | 4 ++-- 2 files changed, 4 insertio