Re: [RFC 04/42] drivers/dma: don't check resource with devm_ioremap_resource

2013-05-12 Thread Wolfram Sang
> > > > >>> devm_ioremap_resource does sanity checks on the given resource. No > > > > >>> need to > > > > >>> duplicate this in the driver. > > > > >> > > > > >>> diff --git a/drivers/dma/tegra20-apb-dma.c > > > > >>> b/drivers/dma/tegra20-apb-dma.c > > > > >> > > > > >>> res = platform_get

Re: [RFC 04/42] drivers/dma: don't check resource with devm_ioremap_resource

2013-05-12 Thread Vinod Koul
On Sun, May 12, 2013 at 08:28:07PM +0200, Wolfram Sang wrote: > On Sun, May 12, 2013 at 09:34:40PM +0530, Vinod Koul wrote: > > On Fri, May 10, 2013 at 01:25:36PM -0600, Stephen Warren wrote: > > > On 05/10/2013 11:57 AM, Wolfram Sang wrote: > > > > On Fri, May 10, 2013 at 10:35:32AM -0600, Stephen

Re: [RFC 04/42] drivers/dma: don't check resource with devm_ioremap_resource

2013-05-12 Thread Wolfram Sang
On Sun, May 12, 2013 at 09:34:40PM +0530, Vinod Koul wrote: > On Fri, May 10, 2013 at 01:25:36PM -0600, Stephen Warren wrote: > > On 05/10/2013 11:57 AM, Wolfram Sang wrote: > > > On Fri, May 10, 2013 at 10:35:32AM -0600, Stephen Warren wrote: > > >> On 05/10/2013 02:16 AM, Wolfram Sang wrote: > >

Re: [RFC 04/42] drivers/dma: don't check resource with devm_ioremap_resource

2013-05-12 Thread Vinod Koul
On Fri, May 10, 2013 at 01:25:36PM -0600, Stephen Warren wrote: > On 05/10/2013 11:57 AM, Wolfram Sang wrote: > > On Fri, May 10, 2013 at 10:35:32AM -0600, Stephen Warren wrote: > >> On 05/10/2013 02:16 AM, Wolfram Sang wrote: > >>> devm_ioremap_resource does sanity checks on the given resource. No

Re: [RFC 04/42] drivers/dma: don't check resource with devm_ioremap_resource

2013-05-10 Thread Stephen Warren
On 05/10/2013 11:57 AM, Wolfram Sang wrote: > On Fri, May 10, 2013 at 10:35:32AM -0600, Stephen Warren wrote: >> On 05/10/2013 02:16 AM, Wolfram Sang wrote: >>> devm_ioremap_resource does sanity checks on the given resource. No need to >>> duplicate this in the driver. >> >>> diff --git a/drivers/d

Re: [RFC 04/42] drivers/dma: don't check resource with devm_ioremap_resource

2013-05-10 Thread Wolfram Sang
On Fri, May 10, 2013 at 10:35:32AM -0600, Stephen Warren wrote: > On 05/10/2013 02:16 AM, Wolfram Sang wrote: > > devm_ioremap_resource does sanity checks on the given resource. No need to > > duplicate this in the driver. > > > diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-

Re: [RFC 04/42] drivers/dma: don't check resource with devm_ioremap_resource

2013-05-10 Thread Stephen Warren
On 05/10/2013 02:16 AM, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > -

[RFC 04/42] drivers/dma: don't check resource with devm_ioremap_resource

2013-05-10 Thread Wolfram Sang
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang --- drivers/dma/tegra20-apb-dma.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index fc