Re: [RFC] setxattr bugs

2013-02-05 Thread Casey Schaufler
On 2/4/2013 6:14 PM, Jeff Mahoney wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 2/2/13 11:30 PM, Al Viro wrote: >> * JFS, since 2005: setxattr(name, "system.posix_acl_access", NULL, >> 0, 0) succeeds, creating an empty EA with "system.posix_acl_access" >> as name. Validity checks

Re: [RFC] setxattr bugs

2013-02-04 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2/2/13 11:30 PM, Al Viro wrote: > * JFS, since 2005: setxattr(name, "system.posix_acl_access", NULL, > 0, 0) succeeds, creating an empty EA with "system.posix_acl_access" > as name. Validity checks should apply _after_ if (value == NULL) { > /* empt

Re: [RFC] setxattr bugs

2013-02-03 Thread Dave Kleikamp
On 02/02/2013 10:30 PM, Al Viro wrote: > * JFS, since 2005: setxattr(name, "system.posix_acl_access", NULL, 0, 0) > succeeds, creating an empty EA with "system.posix_acl_access" as name. > Validity checks should apply _after_ > if (value == NULL) {/* empty EA, do not remove */ >

[RFC] setxattr bugs

2013-02-02 Thread Al Viro
* JFS, since 2005: setxattr(name, "system.posix_acl_access", NULL, 0, 0) succeeds, creating an empty EA with "system.posix_acl_access" as name. Validity checks should apply _after_ if (value == NULL) {/* empty EA, do not remove */ value = ""; valu