Re: [RFC] perf probe: Fix offline module name missmatch issue

2016-04-26 Thread Ravi Bangoria
On Tuesday 26 April 2016 04:16 PM, Masami Hiramatsu wrote: On Tue, 26 Apr 2016 14:26:48 +0530 Ravi Bangoria wrote: Thanks Masami for reviewing. Please find my replies to your comment. On Tuesday 26 April 2016 02:54 AM, Masami Hiramatsu wrote: Hi Ravi, On Mon, 25 Apr 2016 16:08:27 +0530 R

Re: [RFC] perf probe: Fix offline module name missmatch issue

2016-04-26 Thread Masami Hiramatsu
On Tue, 26 Apr 2016 14:26:48 +0530 Ravi Bangoria wrote: > Thanks Masami for reviewing. > > Please find my replies to your comment. > > On Tuesday 26 April 2016 02:54 AM, Masami Hiramatsu wrote: > > Hi Ravi, > > > > On Mon, 25 Apr 2016 16:08:27 +0530 > > Ravi Bangoria wrote: > > > >> Perf can a

Re: [RFC] perf probe: Fix offline module name missmatch issue

2016-04-26 Thread Ravi Bangoria
On Tuesday 26 April 2016 02:45 PM, Wangnan (F) wrote: On 2016/4/26 16:56, Ravi Bangoria wrote: Thanks Masami for reviewing. Please find my replies to your comment. On Tuesday 26 April 2016 02:54 AM, Masami Hiramatsu wrote: Hi Ravi, On Mon, 25 Apr 2016 16:08:27 +0530 Ravi Bangoria wrote:

Re: [RFC] perf probe: Fix offline module name missmatch issue

2016-04-26 Thread Wangnan (F)
On 2016/4/26 16:56, Ravi Bangoria wrote: Thanks Masami for reviewing. Please find my replies to your comment. On Tuesday 26 April 2016 02:54 AM, Masami Hiramatsu wrote: Hi Ravi, On Mon, 25 Apr 2016 16:08:27 +0530 Ravi Bangoria wrote: Perf can add a probe on kernel module which has not be

Re: [RFC] perf probe: Fix offline module name missmatch issue

2016-04-26 Thread Ravi Bangoria
Thanks Masami, On Tuesday 26 April 2016 07:49 AM, Masami Hiramatsu wrote: On Tue, 26 Apr 2016 06:24:38 +0900 Masami Hiramatsu wrote: +/* + * NOTE: + * '.gnu.linkonce.this_module' section of kernel module elf directly + * maps to 'struct module' from linux/module.h. This section contains + * ac

Re: [RFC] perf probe: Fix offline module name missmatch issue

2016-04-26 Thread Ravi Bangoria
Thanks Masami for reviewing. Please find my replies to your comment. On Tuesday 26 April 2016 02:54 AM, Masami Hiramatsu wrote: Hi Ravi, On Mon, 25 Apr 2016 16:08:27 +0530 Ravi Bangoria wrote: Perf can add a probe on kernel module which has not been loaded yet. Current implementation finds

Re: [RFC] perf probe: Fix offline module name missmatch issue

2016-04-25 Thread Masami Hiramatsu
On Tue, 26 Apr 2016 06:24:38 +0900 Masami Hiramatsu wrote: > > +/* > > + * NOTE: > > + * '.gnu.linkonce.this_module' section of kernel module elf directly > > + * maps to 'struct module' from linux/module.h. This section contains > > + * actual module name which will be used by kernel after loadin

Re: [RFC] perf probe: Fix offline module name missmatch issue

2016-04-25 Thread Masami Hiramatsu
Hi Ravi, On Mon, 25 Apr 2016 16:08:27 +0530 Ravi Bangoria wrote: > Perf can add a probe on kernel module which has not been loaded yet. > Current implementation finds module name from path. But if filename > is different from actual module name then perf fails to register > probe while loading m

[RFC] perf probe: Fix offline module name missmatch issue

2016-04-25 Thread Ravi Bangoria
Perf can add a probe on kernel module which has not been loaded yet. Current implementation finds module name from path. But if filename is different from actual module name then perf fails to register probe while loading module because of mismatch in names. For example, samples/kobject/kobject-exa