Re: [RFC] perf: proposed perf_event_open() manpage

2012-10-24 Thread Vince Weaver
below is an updated version of the manpage. It has the changes you suggested plus a few other additions. Please verify the "sample_type" changes. I did some digging in the kernel source and added some info to some of the descriptions. I also added /proc/sys/kernel/ and /sys/bus/event_sour

Re: [RFC] perf: proposed perf_event_open() manpage

2012-10-24 Thread Vince Weaver
On Wed, 24 Oct 2012, Namhyung Kim wrote: > > .BI "int perf_event_open(struct perf_event_attr *" hw_event , > > hw_event? Looks unusual.. how about 'attr'? this (and some of the other stuff) is because the manpage used the somewhat out of date "tools/perf/design.txt" as a reference. It looks l

Re: [RFC] perf: proposed perf_event_open() manpage

2012-10-23 Thread Namhyung Kim
Hi Vince, Great work! On Tue, 23 Oct 2012 11:35:13 -0400 (EDT), Vince Weaver wrote: > Hello > > attached is a proposed manpage for the perf_event_open() system call. > > I'd appreciate any review or comments, especially for the parts marked > as FIXME or "[To be documented]" > > This system call