On Tue, Nov 24, 2020 at 12:19:34AM -0800, Stephane Eranian wrote:
> Hi,
>
> Another remark on the PEBS drainage code, it seems to me like a test
> is not quite correct:
> intel_pmu_drain_pebs_nhm()
> {
> ...
>if (p->status != (1ULL << bit)) {
> for_each_set_
On Tue, Nov 24, 2020 at 5:10 PM Peter Zijlstra wrote:
>
> On Tue, Nov 24, 2020 at 02:01:39PM +0900, Namhyung Kim wrote:
>
> > Yes, it's not about __intel_pmu_pebs_event(). I'm looking at
> > intel_pmu_drain_pebs_nhm() specifically. There's code like
> >
> > /* log dropped samples number
Hi,
Another remark on the PEBS drainage code, it seems to me like a test
is not quite correct:
intel_pmu_drain_pebs_nhm()
{
...
if (p->status != (1ULL << bit)) {
for_each_set_bit(i, (unsigned long *)&pebs_status, size)
error[i]
On Tue, Nov 24, 2020 at 02:01:39PM +0900, Namhyung Kim wrote:
> Yes, it's not about __intel_pmu_pebs_event(). I'm looking at
> intel_pmu_drain_pebs_nhm() specifically. There's code like
>
> /* log dropped samples number */
> if (error[bit]) {
> perf_log_lost_samples(
Hi Peter,
On Mon, Nov 23, 2020 at 11:23 PM Peter Zijlstra wrote:
>
> On Sat, Nov 21, 2020 at 11:50:11AM +0900, Namhyung Kim wrote:
> > When large PEBS is enabled, the below warning is triggered:
> >
> > [6070379.453697] WARNING: CPU: 23 PID: 42379 at
> > arch/x86/events/core.c:1466 x86_pmu_sto
On Sat, Nov 21, 2020 at 11:50:11AM +0900, Namhyung Kim wrote:
> When large PEBS is enabled, the below warning is triggered:
>
> [6070379.453697] WARNING: CPU: 23 PID: 42379 at arch/x86/events/core.c:1466
> x86_pmu_stop+0x95/0xa0
> ...
> [6070379.453831] Call Trace:
> [6070379.453840] x86
When large PEBS is enabled, the below warning is triggered:
[6070379.453697] WARNING: CPU: 23 PID: 42379 at arch/x86/events/core.c:1466
x86_pmu_stop+0x95/0xa0
...
[6070379.453831] Call Trace:
[6070379.453840] x86_pmu_del+0x50/0x150
[6070379.453845] event_sched_out.isra.0+0x95/0x200
7 matches
Mail list logo
