Re: [RFC] introduce prepare_to_wait_event()

2013-10-01 Thread Peter Zijlstra
On Tue, Oct 01, 2013 at 07:33:37PM +0200, Oleg Nesterov wrote: > > > if (___wait_is_interruptible(state) && intr) { > > > \ > > > __ret = intr; > > > \ > > Since typeof(__ret) == typeof(intr) gcc can (likely)

Re: [RFC] introduce prepare_to_wait_event()

2013-10-01 Thread Oleg Nesterov
On 10/01, Peter Zijlstra wrote: > > On Tue, Oct 01, 2013 at 07:01:37PM +0200, Oleg Nesterov wrote: > > if (exclusive) > > \ > > __wait.flags = WQ_FLAG_EXCLUSIVE; > > \ > > else

Re: [RFC] introduce prepare_to_wait_event()

2013-10-01 Thread Peter Zijlstra
On Tue, Oct 01, 2013 at 07:01:37PM +0200, Oleg Nesterov wrote: > This patch moves the signal-pending checks and part of DEFINE_WAIT's > code into the new helper: prepare_to_wait_event(). > > Yes, sure, prepare_to_wait_event() becomes a little bit slower than > prepare_to_wait/prepare_to_wait_exclu

[RFC] introduce prepare_to_wait_event()

2013-10-01 Thread Oleg Nesterov
I didn't test is yet, and I did write the changelog. But let me show the patch for review right now, before we all forget the details... On top of Peter's "wait: Collapse __wait_event macros -v4". This patch moves the signal-pending checks and part of DEFINE_WAIT's code into the new helper: prepa