Re: [RFC] hwmon: ina2xx: port to using remap, improve bandwidth.

2015-10-24 Thread Guenter Roeck
On 10/23/2015 01:35 PM, Marc Titinger wrote: Hi Guenter thanks for the review, answers bellow. [ ... ] /* shunt voltage */ -static SENSOR_DEVICE_ATTR(in0_input, S_IRUGO, ina2xx_show_value, NULL, +static SENSOR_DEVICE_ATTR(in0_input, S_IRUGO, ina2xx_show_shunt, NULL, INA2XX_

Re: [RFC] hwmon: ina2xx: port to using remap, improve bandwidth.

2015-10-23 Thread Guenter Roeck
On 10/23/2015 01:35 PM, Marc Titinger wrote: Hi Guenter thanks for the review, answers bellow. Marc. [ ... ] -/* - * Ina226 has a variable update_interval. For ina219 we - * use a constant value. +/* Check for shunt resistor value. Another comment: Standard multi-line com

Re: [RFC] hwmon: ina2xx: port to using remap, improve bandwidth.

2015-10-23 Thread Marc Titinger
Hi Guenter thanks for the review, answers bellow. Marc. Le 23/10/2015 18:52, Guenter Roeck a écrit : On 10/23/2015 09:13 AM, Marc Titinger wrote: With the current implementation, the driver will prevent a readout at a pace faster than the default conversion time (2ms) times the averaging sett

Re: [RFC] hwmon: ina2xx: port to using remap, improve bandwidth.

2015-10-23 Thread kbuild test robot
Hi Marc, [auto build test WARNING on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Marc-Titinger/hwmon-ina2xx-port-to-using-remap-improve-bandwidth/20151024-001809 config: openrisc-ally

Re: [RFC] hwmon: ina2xx: port to using remap, improve bandwidth.

2015-10-23 Thread kbuild test robot
Hi Marc, [auto build test WARNING on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Marc-Titinger/hwmon-ina2xx-port-to-using-remap-improve-bandwidth/20151024-001809 config: xtensa-allyes

Re: [RFC] hwmon: ina2xx: port to using remap, improve bandwidth.

2015-10-23 Thread Guenter Roeck
On 10/23/2015 09:13 AM, Marc Titinger wrote: With the current implementation, the driver will prevent a readout at a pace faster than the default conversion time (2ms) times the averaging setting, min AVG being 1:1. Any sysfs "show" read access from the client app faster than 500 Hz will be 50

Re: [RFC] hwmon: ina2xx: port to using remap, improve bandwidth.

2015-10-23 Thread kbuild test robot
Hi Marc, [auto build test WARNING on hwmon/hwmon-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Marc-Titinger/hwmon-ina2xx-port-to-using-remap-improve-bandwidth/20151024-001809 config: x86_64-randco

[RFC] hwmon: ina2xx: port to using remap, improve bandwidth.

2015-10-23 Thread Marc Titinger
With the current implementation, the driver will prevent a readout at a pace faster than the default conversion time (2ms) times the averaging setting, min AVG being 1:1. Any sysfs "show" read access from the client app faster than 500 Hz will be 'cached' by the driver, but actually since do_updat