Re: [RFC] component: Fix: Unassign components' masters if bringing up master fails

2016-02-15 Thread Archit Taneja
On 02/16/2016 01:02 AM, Jon Medhurst (Tixy) wrote: On Thu, 2016-02-11 at 15:05 +0530, Archit Taneja wrote: component_master_add_with_match can fail if the master's bind op doesn't go through successfully. In such a scenario, all the components in the master's match array have their 'master' poi

Re: [RFC] component: Fix: Unassign components' masters if bringing up master fails

2016-02-15 Thread Russell King - ARM Linux
On Mon, Feb 15, 2016 at 07:32:02PM +, Jon Medhurst (Tixy) wrote: > It seems to me that for other error cases (that don't result in deletion > of objects) we would want to leave the references between components and > masters intact once they have been created. Indeed we do - because we want to

Re: [RFC] component: Fix: Unassign components' masters if bringing up master fails

2016-02-15 Thread Jon Medhurst (Tixy)
On Thu, 2016-02-11 at 15:05 +0530, Archit Taneja wrote: > component_master_add_with_match can fail if the master's bind op doesn't > go through successfully. In such a scenario, all the components in the > master's match array have their 'master' pointer set to the given master. > These pointers ne

Re: [RFC] component: Fix: Unassign components' masters if bringing up master fails

2016-02-15 Thread Daniel Stone
Hi Archit, On 11 February 2016 at 09:35, Archit Taneja wrote: > component_master_add_with_match can fail if the master's bind op doesn't > go through successfully. In such a scenario, all the components in the > master's match array have their 'master' pointer set to the given master. > These poi

[RFC] component: Fix: Unassign components' masters if bringing up master fails

2016-02-11 Thread Archit Taneja
component_master_add_with_match can fail if the master's bind op doesn't go through successfully. In such a scenario, all the components in the master's match array have their 'master' pointer set to the given master. These pointers need to be set to NULL again. If they aren't, successive calls to