Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-10-06 Thread Martin Schwidefsky
On Mon, 5 Oct 2015 19:09:14 +0200 "Luis R. Rodriguez" wrote: > On Sun, Oct 04, 2015 at 09:02:04PM +0200, Arnd Bergmann wrote: > > On Saturday 03 October 2015 01:53:46 Luis R. Rodriguez wrote: > > > > > > > > Hmm, my gut feeling tells me that your approach won't solve the problem > > > > in gener

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-10-05 Thread Luis R. Rodriguez
On Sun, Oct 04, 2015 at 09:02:04PM +0200, Arnd Bergmann wrote: > On Saturday 03 October 2015 01:53:46 Luis R. Rodriguez wrote: > > > > > > Hmm, my gut feeling tells me that your approach won't solve the problem > > > in general. s390 PCI is just weird in many ways and it will occasionally > > > su

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-10-05 Thread Luis R. Rodriguez
On Sat, Oct 03, 2015 at 05:14:20PM -0700, Randy Dunlap wrote: > On 10/02/15 16:17, Luis R. Rodriguez wrote: > > On Fri, Aug 28, 2015 at 07:13:08PM -0700, Randy Dunlap wrote: > >> On 08/28/15 17:17, Luis R. Rodriguez wrote: > >>> > >>> arch/s390/Kconfig | 8 + > >>> arch/s390/i

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-10-04 Thread Arnd Bergmann
On Saturday 03 October 2015 01:53:46 Luis R. Rodriguez wrote: > > > > Hmm, my gut feeling tells me that your approach won't solve the problem > > in general. s390 PCI is just weird in many ways and it will occasionally > > suffer from problems like this (as do other aspects of the s390 architectur

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-10-03 Thread Randy Dunlap
On 10/02/15 16:17, Luis R. Rodriguez wrote: > On Fri, Aug 28, 2015 at 07:13:08PM -0700, Randy Dunlap wrote: >> On 08/28/15 17:17, Luis R. Rodriguez wrote: >>> >>> arch/s390/Kconfig | 8 + >>> arch/s390/include/asm/io.h| 11 --- >>> arch/s390/include/asm/pci.h

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-10-02 Thread Luis R. Rodriguez
On Fri, Sep 11, 2015 at 10:14:09AM +0200, Martin Schwidefsky wrote: > On Tue, 08 Sep 2015 15:42:40 +0200 > Arnd Bergmann wrote: > > > On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > > > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > > > On Friday 28 August 20

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-10-02 Thread Luis R. Rodriguez
On Tue, Sep 08, 2015 at 03:42:40PM +0200, Arnd Bergmann wrote: > On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > > > While at it, as with the iorem

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-10-02 Thread Luis R. Rodriguez
On Fri, Aug 28, 2015 at 07:13:08PM -0700, Randy Dunlap wrote: > On 08/28/15 17:17, Luis R. Rodriguez wrote: > > > > arch/s390/Kconfig | 8 + > > arch/s390/include/asm/io.h| 11 --- > > arch/s390/include/asm/pci.h | 2 -- > > arch/s390/include/asm/pci_iomap.

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-09-11 Thread Martin Schwidefsky
On Tue, 08 Sep 2015 15:42:40 +0200 Arnd Bergmann wrote: > On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > > > While at it, as with the ioremap*()

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-09-08 Thread Arnd Bergmann
On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > > While at it, as with the ioremap*() variants, since we have no clear > > > semantics yet well defined

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-09-08 Thread Luis R. Rodriguez
On Wed, Sep 2, 2015 at 6:47 PM, Luis R. Rodriguez wrote: > On Wed, Sep 2, 2015 at 6:44 PM, Luis R. Rodriguez wrote: >>> I don't think we really need to spell it out here. s390 PCI is different >>> from everybody else's in a lot of ways, so a simple 'depends on PCI && >>> !S390' for CONFIG_PCI_IOM

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-09-02 Thread Luis R. Rodriguez
On Wed, Sep 2, 2015 at 6:44 PM, Luis R. Rodriguez wrote: >> I don't think we really need to spell it out here. s390 PCI is different >> from everybody else's in a lot of ways, so a simple 'depends on PCI && >> !S390' for CONFIG_PCI_IOMAP seems simpler and more intuitive. > > Sure that would work a

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-09-02 Thread Luis R. Rodriguez
On Sat, Aug 29, 2015 at 08:25:05AM -0700, Christoph Hellwig wrote: > On Fri, Aug 28, 2015 at 05:17:27PM -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > The S390 architecture requires a custom pci_iomap() implementation > > as the asm-generic implementation assumes there are

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-09-02 Thread Luis R. Rodriguez
On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > The S390 architecture requires a custom pci_iomap() implementation > > as the asm-generic implementation assumes there are disjunctions

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-08-30 Thread Arnd Bergmann
On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > The S390 architecture requires a custom pci_iomap() implementation > as the asm-generic implementation assumes there are disjunctions > between PCI BARs, and on S390 PCI BAR are not disjunctive, S390 requir

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-08-29 Thread Christoph Hellwig
On Fri, Aug 28, 2015 at 05:17:27PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > The S390 architecture requires a custom pci_iomap() implementation > as the asm-generic implementation assumes there are disjunctions > between PCI BARs, and on S390 PCI BAR are not disjunctive, S39

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-08-28 Thread Randy Dunlap
On 08/28/15 17:17, Luis R. Rodriguez wrote: > > arch/s390/Kconfig | 8 + > arch/s390/include/asm/io.h| 11 --- > arch/s390/include/asm/pci.h | 2 -- > arch/s390/include/asm/pci_iomap.h | 33 + > arch/s390/pci/pci.c | 2 ++

[RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

2015-08-28 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The S390 architecture requires a custom pci_iomap() implementation as the asm-generic implementation assumes there are disjunctions between PCI BARs, and on S390 PCI BAR are not disjunctive, S390 requires the bar parameter in order to find the corresponding device and cr