Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops

2007-02-27 Thread Anthony Liguori
Zachary Amsden wrote: Anthony Liguori wrote: Hi Zach, It seems to me that the APIC paravirt_ops should be filled by para_fill() instead of vmi_get_function(). vmi_get_function() returns a nop when the relocation type is NONE. para_fill() leaves the native code in place. The native versio

Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops

2007-02-26 Thread Jeremy Fitzhardinge
Zachary Amsden wrote: > Patch looks good, thanks. But the whole para_fill / vmi_get_function > stuff could probably be done even cleaner. It was just a helper at > first to work around the awkward syntax, and it is still a bit ugly, > but I haven't come up with a better solution yet, mostly beca

Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops

2007-02-26 Thread Zachary Amsden
Anthony Liguori wrote: It would be really great if one could write a ROM by just specifying a GetRelocationInfo function that always returns rel.type == NONE. Right now, there are a half a dozen or so ops that have to be implemented b/c of the vmi_get_function stuff. Yes, I need to clean t

Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops

2007-02-26 Thread Anthony Liguori
Zachary Amsden wrote: Anthony Liguori wrote: Hi Zach, It seems to me that the APIC paravirt_ops should be filled by para_fill() instead of vmi_get_function(). vmi_get_function() returns a nop when the relocation type is NONE. para_fill() leaves the native code in place. The native versio

Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops

2007-02-26 Thread Zachary Amsden
Anthony Liguori wrote: Hi Zach, It seems to me that the APIC paravirt_ops should be filled by para_fill() instead of vmi_get_function(). vmi_get_function() returns a nop when the relocation type is NONE. para_fill() leaves the native code in place. The native version of the apic write ops

[RFC] Use para_fill instead of vmi_get_function for APIC ops

2007-02-26 Thread Anthony Liguori
Hi Zach, It seems to me that the APIC paravirt_ops should be filled by para_fill() instead of vmi_get_function(). vmi_get_function() returns a nop when the relocation type is NONE. para_fill() leaves the native code in place. The native version of the apic write ops is more or less *(APIC_