Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-16 Thread Marc Zyngier
On Fri, 16 Apr 2021 02:13:38 +0100, Kever Yang wrote: > > Hi Marc, > > On 2021/4/15 下午4:11, Marc Zyngier wrote: > > Hi Kever, > > > > On Thu, 15 Apr 2021 08:24:33 +0100, > > Kever Yang wrote: > >> Hi Marc, Peter, > >> > >>     RK356x GIC has two issues: > >> > >> 1. GIC only support 32bit a

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-15 Thread Kever Yang
Hi Marc, On 2021/4/15 下午4:11, Marc Zyngier wrote: Hi Kever, On Thu, 15 Apr 2021 08:24:33 +0100, Kever Yang wrote: Hi Marc, Peter,     RK356x GIC has two issues: 1. GIC only support 32bit address while rk356x supports 8GB DDR SDRAM, so we use ZONE_DMA32 to fix this issue; What transactions

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-15 Thread Marc Zyngier
Hi Kever, On Thu, 15 Apr 2021 08:24:33 +0100, Kever Yang wrote: > > Hi Marc, Peter, > >     RK356x GIC has two issues: > > 1. GIC only support 32bit address while rk356x supports 8GB DDR SDRAM, > so we use ZONE_DMA32 to fix this issue; What transactions does this affect exactly? Only some ITS

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-15 Thread Kever Yang
Hi Marc, Peter,     RK356x GIC has two issues: 1. GIC only support 32bit address while rk356x supports 8GB DDR SDRAM, so we use ZONE_DMA32 to fix this issue; 2. GIC version is r1p6-00rel0, RK356x interconnect does not support GIC and CPU snoop to each other, hence the GIC does not support th

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-14 Thread Marc Zyngier
On Wed, 14 Apr 2021 12:41:20 +0100, Peter Geis wrote: > > On Tue, Apr 13, 2021 at 11:51 AM Marc Zyngier wrote: > > > > On Tue, 13 Apr 2021 16:03:51 +0100, > > Peter Geis wrote: > > > > > > On Tue, Apr 13, 2021 at 10:01 AM Marc Zyngier wrote: > > > > [...] > > > > > > What happens if you hack a

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-14 Thread Peter Geis
On Tue, Apr 13, 2021 at 11:51 AM Marc Zyngier wrote: > > On Tue, 13 Apr 2021 16:03:51 +0100, > Peter Geis wrote: > > > > On Tue, Apr 13, 2021 at 10:01 AM Marc Zyngier wrote: > > [...] > > > > What happens if you hack all the allocations to happen in the low 4GB > > > of the PA space? > > > > It

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-13 Thread Marc Zyngier
On Tue, 13 Apr 2021 16:03:51 +0100, Peter Geis wrote: > > On Tue, Apr 13, 2021 at 10:01 AM Marc Zyngier wrote: [...] > > What happens if you hack all the allocations to happen in the low 4GB > > of the PA space? > > It seems to work correctly. > The downstream hacks used GFP_DMA32 which gets

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-13 Thread Peter Geis
On Tue, Apr 13, 2021 at 10:01 AM Marc Zyngier wrote: > > On Tue, 13 Apr 2021 14:29:32 +0100, > Peter Geis wrote: > > > > On Tue, Apr 13, 2021 at 5:23 AM Marc Zyngier wrote: > > > > > > Hi Peter, > > > > > > On Mon, 12 Apr 2021 21:49:59 +0100, > > > Peter Geis wrote: > > > > > > > > Good Afterno

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-13 Thread Marc Zyngier
Hi Peter, On Mon, 12 Apr 2021 21:49:59 +0100, Peter Geis wrote: > > Good Afternoon, > > I am assisting with early bringup of the rk3566 based quartz64 > development board for mainline linux. > I've encountered a few issues with allocating ITS on their version of > the GIC-V3. > The first issue

[RFC] ITS fails to allocate on rk3568/rk3566

2021-04-12 Thread Peter Geis
Good Afternoon, I am assisting with early bringup of the rk3566 based quartz64 development board for mainline linux. I've encountered a few issues with allocating ITS on their version of the GIC-V3. The first issue is the ITS controller can only use 32bit addresses. This leads to the following err