Re: [RFC] Consistently use the name asm-offsets.h

2005-09-09 Thread Jan-Benedict Glaw
On Thu, 2005-09-08 23:15:39 +0200, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > I suggest moving all the logic required to build the asm-offsets.h file > to a common places and do proper search&replace in architectures to make > the naming consitent. For frv, m32r and sparc64 we will need to create a

Re: [RFC] Consistently use the name asm-offsets.h

2005-09-09 Thread Ralf Baechle
On Thu, Sep 08, 2005 at 11:47:42PM +0200, Sam Ravnborg wrote: > mips has it own private gen-asm-offset macro, > > The important part being: > > sed -ne "/^@@@/s///p"; \ > > compared to the generic one: > > sed -ne "/^->/{s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 > */:; s:->::

Re: [RFC] Consistently use the name asm-offsets.h

2005-09-09 Thread Paul Jackson
Brian wrote: > The right fix is to get rid of that god-awful circular dependency on > offset.h Just try making such a patch. I double triple dare you. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <[EMAIL

Re: [RFC] Consistently use the name asm-offsets.h

2005-09-08 Thread Brian Gerst
Luck, Tony wrote: The existing ia64 specific rule to generate offsets.h has to "echo #define IA64_TASK_SIZE 0 > include/asm-ia64/offsets.h" before building asm-offsets.s to avoid compilation errors. So long as you take care of this somehow in the generic version, go wild. The right fix is to

Re: [RFC] Consistently use the name asm-offsets.h

2005-09-08 Thread Sam Ravnborg
mips has it own private gen-asm-offset macro, The important part being: sed -ne "/^@@@/s///p"; \ compared to the generic one: sed -ne "/^->/{s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; s:->::; p;}"; \ I wonder why the assembly for mips is so different... So for now two arc

RE: [RFC] Consistently use the name asm-offsets.h

2005-09-08 Thread Luck, Tony
The existing ia64 specific rule to generate offsets.h has to "echo #define IA64_TASK_SIZE 0 > include/asm-ia64/offsets.h" before building asm-offsets.s to avoid compilation errors. So long as you take care of this somehow in the generic version, go wild. -Tony

[RFC] Consistently use the name asm-offsets.h

2005-09-08 Thread Sam Ravnborg
Today all architectures expect 3 generate an asm-offsets.h file. The exceptions are: frv, m32r, sparc64 Most architectures uses a name similar to asm_offsets.h with small differences. A few uses asm-consts.h and a few uses '-' instead of '_'. I suggest moving all the logic required to build the a