Re: [RFC] 3.16-rc6 -- fs/direct-io.c:1011 from and to uninitialized.

2014-07-22 Thread Ian Kumlien
On tis, 2014-07-22 at 12:20 -0700, Randy Dunlap wrote: > On 07/22/2014 12:03 PM, Ian Kumlien wrote: > > This is a resend, try two... > > > > And while the fix is simple, something along the lines of: > > diff --git a/fs/direct-io.c b/fs/direct-io.c > > index 98040ba..64a8286 100644 > > --- a/fs/d

Re: [RFC] 3.16-rc6 -- fs/direct-io.c:1011 from and to uninitialized.

2014-07-22 Thread Randy Dunlap
On 07/22/2014 12:03 PM, Ian Kumlien wrote: > This is a resend, try two... > > --- > Hi, > > While playing around compiling the kernel i noticed the following: > fs/direct-io.c: In function ‘do_blockdev_direct_IO’: > fs/direct-io.c:1022:29: warning: ‘from’ may be used uninitialized in > this func

Re: [RFC] 3.16-rc6 -- fs/direct-io.c:1011 from and to uninitialized.

2014-07-22 Thread Ian Kumlien
On tis, 2014-07-22 at 21:12 +0200, Richard Weinberger wrote: > On Tue, Jul 22, 2014 at 9:03 PM, Ian Kumlien wrote: > > This is a resend, try two... > > Please see "[PATCH v3] direct-io: fix uninitialized warning in > do_direct_IO()". That looks like a better approach, couldn't find it before i

Re: [RFC] 3.16-rc6 -- fs/direct-io.c:1011 from and to uninitialized.

2014-07-22 Thread Richard Weinberger
On Tue, Jul 22, 2014 at 9:03 PM, Ian Kumlien wrote: > This is a resend, try two... Please see "[PATCH v3] direct-io: fix uninitialized warning in do_direct_IO()". > --- > Hi, > > While playing around compiling the kernel i noticed the following: > fs/direct-io.c: In function ‘do_blockdev_direct_

[RFC] 3.16-rc6 -- fs/direct-io.c:1011 from and to uninitialized.

2014-07-22 Thread Ian Kumlien
This is a resend, try two... --- Hi, While playing around compiling the kernel i noticed the following: fs/direct-io.c: In function ‘do_blockdev_direct_IO’: fs/direct-io.c:1022:29: warning: ‘from’ may be used uninitialized in this function [-Wmaybe-uninitialized] ret = submit_page_section(di