Re: [RFC] [PATCH] fix infinite loop; increase robustness of debugfs_remove_recursive [attached test module]

2012-11-28 Thread Steven Rostedt
On Wed, 2012-11-28 at 10:37 +0100, Lars Ellenberg wrote: > On Tue, Nov 27, 2012 at 10:16:28PM -0500, Steven Rostedt wrote: > > On Fri, 2012-11-23 at 18:15 +0100, Lars Ellenberg wrote: > > > When toying around with debugfs, intentionally trying to break things, > > > I managed to get it into a repro

Re: [RFC] [PATCH] fix infinite loop; increase robustness of debugfs_remove_recursive [attached test module]

2012-11-28 Thread Lars Ellenberg
On Wed, Nov 28, 2012 at 10:37:54AM +0100, Lars Ellenberg wrote: > Note that all but rmmod may be done as normal user, Ok, that is not exactly correct, I forgot about debugfs being mounted 0700 ;-) Still... Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [RFC] [PATCH] fix infinite loop; increase robustness of debugfs_remove_recursive [attached test module]

2012-11-28 Thread Lars Ellenberg
On Tue, Nov 27, 2012 at 10:16:28PM -0500, Steven Rostedt wrote: > On Fri, 2012-11-23 at 18:15 +0100, Lars Ellenberg wrote: > > When toying around with debugfs, intentionally trying to break things, > > I managed to get it into a reproducible endless loop when cleaning up. > > > > debugfs_remove_re

Re: [RFC] [PATCH] fix infinite loop; increase robustness of debugfs_remove_recursive

2012-11-27 Thread Steven Rostedt
On Fri, 2012-11-23 at 18:15 +0100, Lars Ellenberg wrote: > When toying around with debugfs, intentionally trying to break things, > I managed to get it into a reproducible endless loop when cleaning up. > > debugfs_remove_recursive() completely ignores that entries found > on ->d_subdirs may alrea

[RFC] [PATCH] fix infinite loop; increase robustness of debugfs_remove_recursive

2012-11-23 Thread Lars Ellenberg
When toying around with debugfs, intentionally trying to break things, I managed to get it into a reproducible endless loop when cleaning up. debugfs_remove_recursive() completely ignores that entries found on ->d_subdirs may already be d_delete()d, but not yet d_kill()ed. In this case, the firs