RE: [RFC][PATCH v3 2/3] efi_pstore: Introducing workqueue updating sysfs entries

2012-08-21 Thread Seiji Aguchi
> > efivars_exit(void) > > { > > if (efi_enabled) { > > + cancel_work_sync(&efivar_work); > > Please move this cancel_work_sync() to be before the efi_enabled test. > efi_enabled here means that we registered __efivars. There may be another > driver (gsmi) using the efiv

Re: [RFC][PATCH v3 2/3] efi_pstore: Introducing workqueue updating sysfs entries

2012-08-21 Thread Mike Waychison
On Tue, Aug 21, 2012 at 9:54 AM, Seiji Aguchi wrote: > [Problem] > efi_pstore creates sysfs entries ,which enable users to access to NVRAM, > in a write callback. If a kernel panic happens in interrupt contexts, > pstore may > fail because it could sleep due to dynamic memory allocations du

[RFC][PATCH v3 2/3] efi_pstore: Introducing workqueue updating sysfs entries

2012-08-21 Thread Seiji Aguchi
[Problem] efi_pstore creates sysfs entries ,which enable users to access to NVRAM, in a write callback. If a kernel panic happens in interrupt contexts, pstore may fail because it could sleep due to dynamic memory allocations during creating sysfs entries. [Patch Description] This patch r