Re: [RFC][PATCH V2] GCOV: profile by modules

2020-05-20 Thread Cixi Geng
>> +config SERIAL_GCOV >> + bool "open gcov for serial" >What do you mean by "open"? And Kconfig entries are usually Upper Case" :) >> + depends on GCOV_PROFILE_PREREQS >> + help >> + Say Y here to enable gcov in serial. >I think we need more text here. Maybe I should

Re: [RFC][PATCH V2] GCOV: profile by modules

2020-05-20 Thread Cixi Geng
Thank you for guidances, I will fix error and upload new patch Greg KH 于2020年5月20日周三 下午4:51写道： > > On Wed, May 20, 2020 at 04:38:21PM +0800, gengc...@gmail.com wrote: > > From: Cixi Geng > > > > --- > > Replace symbol GCOV_PROFILE_MODULES with GCOV_PROFILE_PREREQS > > --- > > The CONFIG_GCOV_PRO

Re: [RFC][PATCH V2] GCOV: profile by modules

2020-05-20 Thread Greg KH
On Wed, May 20, 2020 at 04:38:21PM +0800, gengc...@gmail.com wrote: > From: Cixi Geng > > --- > Replace symbol GCOV_PROFILE_MODULES with GCOV_PROFILE_PREREQS > --- > The CONFIG_GCOV_PROFILE_ALL will compile kernel by profiling entire > kernel which will lead to kernel run slower.Use GCOV_PROFILE_

Re: [RFC][PATCH V2] GCOV: profile by modules

2020-05-20 Thread Greg KH
On Wed, May 20, 2020 at 04:38:21PM +0800, gengc...@gmail.com wrote: > From: Cixi Geng > > --- > Replace symbol GCOV_PROFILE_MODULES with GCOV_PROFILE_PREREQS > --- That can't go in the body of a changelog, as it will be cut off. Try applying this patch with 'git am' and see what happens :(

[RFC][PATCH V2] GCOV: profile by modules

2020-05-20 Thread gengcixi
From: Cixi Geng --- Replace symbol GCOV_PROFILE_MODULES with GCOV_PROFILE_PREREQS --- The CONFIG_GCOV_PROFILE_ALL will compile kernel by profiling entire kernel which will lead to kernel run slower.Use GCOV_PROFILE_PREREQS to control part of the kernel modules to open gcov. Only add SERIAL_GCOV