Re: [RFC][PATCH 5/9] mm/migrate: demote pages during reclaim

2020-10-27 Thread Yang Shi
On Tue, Oct 27, 2020 at 8:29 AM Oscar Salvador wrote: > > On Wed, Oct 07, 2020 at 09:17:45AM -0700, Dave Hansen wrote: > > Signed-off-by: Dave Hansen > > Cc: Yang Shi > > Cc: David Rientjes > > Cc: Huang Ying > > Cc: Dan Williams > > I am still going through all the details, but just my thoug

Re: [RFC][PATCH 5/9] mm/migrate: demote pages during reclaim

2020-10-27 Thread Oscar Salvador
On Wed, Oct 07, 2020 at 09:17:45AM -0700, Dave Hansen wrote: > Signed-off-by: Dave Hansen > Cc: Yang Shi > Cc: David Rientjes > Cc: Huang Ying > Cc: Dan Williams I am still going through all the details, but just my thoughts on things that caught my eye: > --- a/include/linux/migrate.h~demot

[RFC][PATCH 5/9] mm/migrate: demote pages during reclaim

2020-10-07 Thread Dave Hansen
From: Dave Hansen This is mostly derived from a patch from Yang Shi: https://lore.kernel.org/linux-mm/1560468577-101178-10-git-send-email-yang@linux.alibaba.com/ Add code to the reclaim path (shrink_page_list()) to "demote" data to another NUMA node instead of discarding the data

Re: [RFC][PATCH 5/9] mm/migrate: demote pages during reclaim

2020-08-21 Thread Yang Shi
On Thu, Aug 20, 2020 at 5:57 PM Huang, Ying wrote: > > Yang Shi writes: > > > On Thu, Aug 20, 2020 at 8:22 AM Dave Hansen wrote: > >> > >> On 8/20/20 1:06 AM, Huang, Ying wrote: > >> >> +/* Migrate pages selected for demotion */ > >> >> +nr_reclaimed += demote_page_list(&ret_pages, &demo

Re: [RFC][PATCH 5/9] mm/migrate: demote pages during reclaim

2020-08-20 Thread Huang, Ying
Yang Shi writes: > On Thu, Aug 20, 2020 at 8:22 AM Dave Hansen wrote: >> >> On 8/20/20 1:06 AM, Huang, Ying wrote: >> >> +/* Migrate pages selected for demotion */ >> >> +nr_reclaimed += demote_page_list(&ret_pages, &demote_pages, pgdat, >> >> sc); >> >> + >> >> pgactivate = stat->

Re: [RFC][PATCH 5/9] mm/migrate: demote pages during reclaim

2020-08-20 Thread Yang Shi
On Tue, Aug 18, 2020 at 11:51 AM Dave Hansen wrote: > > > From: Dave Hansen > > This is mostly derived from a patch from Yang Shi: > > > https://lore.kernel.org/linux-mm/1560468577-101178-10-git-send-email-yang@linux.alibaba.com/ > > Add code to the reclaim path (shrink_page_list())

Re: [RFC][PATCH 5/9] mm/migrate: demote pages during reclaim

2020-08-20 Thread Yang Shi
On Thu, Aug 20, 2020 at 8:22 AM Dave Hansen wrote: > > On 8/20/20 1:06 AM, Huang, Ying wrote: > >> +/* Migrate pages selected for demotion */ > >> +nr_reclaimed += demote_page_list(&ret_pages, &demote_pages, pgdat, > >> sc); > >> + > >> pgactivate = stat->nr_activate[0] + stat->nr_ac

Re: [RFC][PATCH 5/9] mm/migrate: demote pages during reclaim

2020-08-20 Thread Dave Hansen
On 8/20/20 1:06 AM, Huang, Ying wrote: >> +/* Migrate pages selected for demotion */ >> +nr_reclaimed += demote_page_list(&ret_pages, &demote_pages, pgdat, sc); >> + >> pgactivate = stat->nr_activate[0] + stat->nr_activate[1]; >> >> mem_cgroup_uncharge_list(&free_pages); >> _ >

Re: [RFC][PATCH 5/9] mm/migrate: demote pages during reclaim

2020-08-20 Thread Huang, Ying
Hi, Dave, Dave Hansen writes: [snip] > diff -puN mm/vmscan.c~demote-with-migrate_pages mm/vmscan.c > --- a/mm/vmscan.c~demote-with-migrate_pages 2020-08-18 11:36:52.919583179 > -0700 > +++ b/mm/vmscan.c 2020-08-18 11:36:52.924583179 -0700 > @@ -43,6 +43,7 @@ > #include > #include >

[RFC][PATCH 5/9] mm/migrate: demote pages during reclaim

2020-08-18 Thread Dave Hansen
From: Dave Hansen This is mostly derived from a patch from Yang Shi: https://lore.kernel.org/linux-mm/1560468577-101178-10-git-send-email-yang@linux.alibaba.com/ Add code to the reclaim path (shrink_page_list()) to "demote" data to another NUMA node instead of discarding the data