Re: [RFC][PATCH 2/4] futex: Use smp_store_release() in mark_wake_futex()

2016-10-04 Thread Peter Zijlstra
On Tue, Oct 04, 2016 at 08:57:55PM -0700, Davidlohr Bueso wrote: > On Mon, 03 Oct 2016, Peter Zijlstra wrote: > > >Since the futex_q can dissapear the instruction after assigning NULL, > >this really should be a RELEASE barrier. That stops loads from hitting > >dead memory too. > > > >Signed-off-b

Re: [RFC][PATCH 2/4] futex: Use smp_store_release() in mark_wake_futex()

2016-10-04 Thread Davidlohr Bueso
On Mon, 03 Oct 2016, Peter Zijlstra wrote: Since the futex_q can dissapear the instruction after assigning NULL, this really should be a RELEASE barrier. That stops loads from hitting dead memory too. Signed-off-by: Peter Zijlstra (Intel) --- kernel/futex.c |3 +-- 1 file changed, 1 inserti

Re: [RFC][PATCH 2/4] futex: Use smp_store_release() in mark_wake_futex()

2016-10-03 Thread Steven Rostedt
On Mon, 03 Oct 2016 11:12:36 +0200 Peter Zijlstra wrote: > Since the futex_q can dissapear the instruction after assigning NULL, > this really should be a RELEASE barrier. That stops loads from hitting > dead memory too. > > Signed-off-by: Peter Zijlstra (Intel) > --- > kernel/futex.c |3 +

[RFC][PATCH 2/4] futex: Use smp_store_release() in mark_wake_futex()

2016-10-03 Thread Peter Zijlstra
Since the futex_q can dissapear the instruction after assigning NULL, this really should be a RELEASE barrier. That stops loads from hitting dead memory too. Signed-off-by: Peter Zijlstra (Intel) --- kernel/futex.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/kernel/futex.c