Re: [RFC][PATCH 2/2] tux3: Use writeback hook to remove duplicated core code

2014-06-02 Thread Daniel Phillips
On 06/01/2014 08:30 PM, Dave Chinner wrote: > I get very worried whenever I see locks inside inode->i_lock. In > general, i_lock is supposed to be the innermost lock that is taken, > and there are very few exceptions to that - the inode LRU list is > one of the few. I generally trust Hirofumi to

Re: [RFC][PATCH 2/2] tux3: Use writeback hook to remove duplicated core code

2014-06-01 Thread Dave Chinner
On Sun, Jun 01, 2014 at 02:42:48PM -0700, Daniel Phillips wrote: > Instead of re-implementing part of fs/fs-writeback.c, use a proposed > net ->writeback super operation to drive delta writeback. For each > inode that is cleaned, call inode_writeback_done(inode). For each > inode that will be kept

[RFC][PATCH 2/2] tux3: Use writeback hook to remove duplicated core code

2014-06-01 Thread Daniel Phillips
Instead of re-implementing part of fs/fs-writeback.c, use a proposed net ->writeback super operation to drive delta writeback. For each inode that is cleaned, call inode_writeback_done(inode). For each inode that will be kept dirty in cache, call inode_writeback_touch so that the inode appears youn