[RFC][PATCH 1/3] Suspend: Testing facility (rev. 2)

2007-11-03 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> Introduce sysfs attribute /sys/power/pm_test allowing one to test the suspend core code. Namely, writing one of the strings: freezer devices platform processors core to this file causes the suspend code to work in one of the test modes defined as foll

Re: [RFC][PATCH 1/3] Suspend: Testing facility

2007-11-03 Thread Rafael J. Wysocki
Hi, On Saturday, 3 November 2007 19:23, Pavel Machek wrote: > Hi! > > > Introduce /sys/power/pm_test_level attribute allowing one to test the > > suspend > > core code. Namely, writing a number (1-5) to this file causes the suspend > > code > > to work in one of the test modes defined as follo

Re: [RFC][PATCH 1/3] Suspend: Testing facility

2007-11-03 Thread Pavel Machek
Hi! > Introduce /sys/power/pm_test_level attribute allowing one to test the suspend > core code. Namely, writing a number (1-5) to this file causes the suspend > code > to work in one of the test modes defined as follows: > > 5 - test the freezing of processes > 4 - test the freezing of process

Re: [linux-pm] [RFC][PATCH 1/3] Suspend: Testing facility

2007-11-02 Thread Rafael J. Wysocki
On Friday, 2 November 2007 11:33, Johannes Berg wrote: > > > 5 - test the freezing of processes > > > +/* Suspend test levels */ > > +enum { > > + TEST_NONE, > > Without reading the code, I assume that this enum controls those levels. > I think a comment that it is user-space visible API and s

Re: [linux-pm] [RFC][PATCH 1/3] Suspend: Testing facility

2007-11-02 Thread Johannes Berg
> 5 - test the freezing of processes > +/* Suspend test levels */ > +enum { > + TEST_NONE, Without reading the code, I assume that this enum controls those levels. I think a comment that it is user-space visible API and should not be reordered would be warranted. johannes signature.asc D

[RFC][PATCH 1/3] Suspend: Testing facility

2007-11-01 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> Introduce /sys/power/pm_test_level attribute allowing one to test the suspend core code. Namely, writing a number (1-5) to this file causes the suspend code to work in one of the test modes defined as follows: 5 - test the freezing of processes 4 - tes