Re: [RFC][PATCH 1/3] PM /devfreq: add user frequency limits into devfreq struct

2021-02-23 Thread Chanwoo Choi
On 2/16/21 7:41 PM, Lukasz Luba wrote: > Hi Chanwoo, > > On 2/15/21 3:00 PM, Chanwoo Choi wrote: >> Hi Lukasz, >> >> On Fri, Feb 12, 2021 at 7:28 AM Lukasz Luba wrote: >>> >>> >>> >>> On 2/11/21 11:07 AM, Lukasz Luba wrote: Hi Chanwoo, On 2/3/21 10:21 AM, Lukasz Luba wrote: > H

Re: [RFC][PATCH 1/3] PM /devfreq: add user frequency limits into devfreq struct

2021-02-16 Thread Lukasz Luba
Hi Chanwoo, On 2/15/21 3:00 PM, Chanwoo Choi wrote: Hi Lukasz, On Fri, Feb 12, 2021 at 7:28 AM Lukasz Luba wrote: On 2/11/21 11:07 AM, Lukasz Luba wrote: Hi Chanwoo, On 2/3/21 10:21 AM, Lukasz Luba wrote: Hi Chanwoo, Thank you for looking at this. On 2/3/21 10:11 AM, Chanwoo Choi wrot

Re: [RFC][PATCH 1/3] PM /devfreq: add user frequency limits into devfreq struct

2021-02-15 Thread Chanwoo Choi
Hi Lukasz, On Fri, Feb 12, 2021 at 7:28 AM Lukasz Luba wrote: > > > > On 2/11/21 11:07 AM, Lukasz Luba wrote: > > Hi Chanwoo, > > > > On 2/3/21 10:21 AM, Lukasz Luba wrote: > >> Hi Chanwoo, > >> > >> Thank you for looking at this. > >> > >> On 2/3/21 10:11 AM, Chanwoo Choi wrote: > >>> Hi Lukasz,

Re: [RFC][PATCH 1/3] PM /devfreq: add user frequency limits into devfreq struct

2021-02-11 Thread Lukasz Luba
On 2/11/21 11:07 AM, Lukasz Luba wrote: Hi Chanwoo, On 2/3/21 10:21 AM, Lukasz Luba wrote: Hi Chanwoo, Thank you for looking at this. On 2/3/21 10:11 AM, Chanwoo Choi wrote: Hi Lukasz, When accessing the max_freq and min_freq at devfreq-cooling.c, even if can access 'user_max_freq' and '

Re: [RFC][PATCH 1/3] PM /devfreq: add user frequency limits into devfreq struct

2021-02-11 Thread Lukasz Luba
Hi Chanwoo, On 2/3/21 10:21 AM, Lukasz Luba wrote: Hi Chanwoo, Thank you for looking at this. On 2/3/21 10:11 AM, Chanwoo Choi wrote: Hi Lukasz, When accessing the max_freq and min_freq at devfreq-cooling.c, even if can access 'user_max_freq' and 'lock' by using the 'devfreq' instance, I th

Re: [RFC][PATCH 1/3] PM /devfreq: add user frequency limits into devfreq struct

2021-02-03 Thread Lukasz Luba
Hi Chanwoo, Thank you for looking at this. On 2/3/21 10:11 AM, Chanwoo Choi wrote: Hi Lukasz, When accessing the max_freq and min_freq at devfreq-cooling.c, even if can access 'user_max_freq' and 'lock' by using the 'devfreq' instance, I think that the direct access of variables (lock/user_max

Re: [RFC][PATCH 1/3] PM /devfreq: add user frequency limits into devfreq struct

2021-02-03 Thread Chanwoo Choi
Hi Lukasz, When accessing the max_freq and min_freq at devfreq-cooling.c, even if can access 'user_max_freq' and 'lock' by using the 'devfreq' instance, I think that the direct access of variables (lock/user_max_freq/user_min_freq) of struct devfreq are not good. Instead, how about using the 'DEV

[RFC][PATCH 1/3] PM /devfreq: add user frequency limits into devfreq struct

2021-01-26 Thread Lukasz Luba
The new fields inside devfreq struct allow to check the frequency limits set by the user via sysfs. These limits are important for thermal governor Intelligent Power Allocation (IPA) which needs to know the maximum allowed power consumption of the device. Signed-off-by: Lukasz Luba --- drivers/d