Re: Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

2018-11-26 Thread Joey Pabalinas
On Mon, Nov 26, 2018 at 04:27:50PM -0500, Steven Rostedt wrote: > On Mon, 26 Nov 2018 00:02:07 -1000 > Joey Pabalinas wrote: > > > On Wed, Nov 21, 2018 at 08:27:16PM -0500, Steven Rostedt wrote: > > > The static inline function task_curr_ret_stack() is unused, remove it. > > > > Just want ot m

Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

2018-11-26 Thread Steven Rostedt
On Mon, 26 Nov 2018 00:02:07 -1000 Joey Pabalinas wrote: > On Wed, Nov 21, 2018 at 08:27:16PM -0500, Steven Rostedt wrote: > > The static inline function task_curr_ret_stack() is unused, remove it. > > Just want ot make sure I understand this correctly, instead of using this > function, the co

Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

2018-11-26 Thread Steven Rostedt
On Mon, 26 Nov 2018 16:40:02 +0900 Masami Hiramatsu wrote: > On Wed, 21 Nov 2018 20:27:16 -0500 > Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > The static inline function task_curr_ret_stack() is unused, remove it. > > This looks able to be applied without this series

Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

2018-11-26 Thread Joey Pabalinas
On Wed, Nov 21, 2018 at 08:27:16PM -0500, Steven Rostedt wrote: > The static inline function task_curr_ret_stack() is unused, remove it. Just want ot make sure I understand this correctly, instead of using this function, the convention now is to just directly assign `t->curr_ret_stack = -1`? --

Re: [RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

2018-11-25 Thread Masami Hiramatsu
On Wed, 21 Nov 2018 20:27:16 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The static inline function task_curr_ret_stack() is unused, remove it. This looks able to be applied without this series. I think we should apply this to for-next branch? Reviewed-by: Masami Hiramat

[RFC][PATCH 08/14] function_graph: Remove unused task_curr_ret_stack()

2018-11-21 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The static inline function task_curr_ret_stack() is unused, remove it. Signed-off-by: Steven Rostedt (VMware) --- include/linux/ftrace.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h index 477ff941