Re: [RFC][PATCH 00/14 v2] function_graph: Rewrite to allow multiple users

2019-06-07 Thread Steven Rostedt
On Thu, 30 May 2019 18:29:20 +0900 Masami Hiramatsu wrote: > > OK, so this series isn't enough to allow kretprobes to use it yet. OK, > > I plan on still keeping it because it does allow for placing function > > graph tracer into instances with their own filters. > > OK, that will be a "regs"

Re: [RFC][PATCH 00/14 v2] function_graph: Rewrite to allow multiple users

2019-05-30 Thread Masami Hiramatsu
On Wed, 29 May 2019 05:25:21 -0400 Steven Rostedt wrote: > On Wed, 29 May 2019 15:47:40 +0900 > Masami Hiramatsu wrote: > > > > Hi Steve, > > > > I found that these interfaces seem tightly coupled with fgraph_ops. But that > > cause a problem when I'm using it from kretprobe. > > I was think

Re: [RFC][PATCH 00/14 v2] function_graph: Rewrite to allow multiple users

2019-05-29 Thread Steven Rostedt
On Wed, 29 May 2019 15:47:40 +0900 Masami Hiramatsu wrote: > Hi Steve, > > I found that these interfaces seem tightly coupled with fgraph_ops. But that > cause a problem when I'm using it from kretprobe. I was thinking that the kretprobes could use the fgraph_ops like kprobes uses ftrace_ops.

Re: [RFC][PATCH 00/14 v2] function_graph: Rewrite to allow multiple users

2019-05-28 Thread Masami Hiramatsu
On Wed, 22 May 2019 10:40:27 -0400 Steven Rostedt wrote: > On Wed, 22 May 2019 23:19:55 +0900 > Masami Hiramatsu wrote: > > > > void *fgraph_reserve_data(int size_in_bytes) > > > > > > Allows the entry function to reserve up to 4 words of data on > > > the shadow stack. On success, a

Re: [RFC][PATCH 00/14 v2] function_graph: Rewrite to allow multiple users

2019-05-22 Thread Steven Rostedt
On Wed, 22 May 2019 23:19:55 +0900 Masami Hiramatsu wrote: > > void *fgraph_reserve_data(int size_in_bytes) > > > > Allows the entry function to reserve up to 4 words of data on > > the shadow stack. On success, a pointer to the contents is returned. > > This may be only called once

Re: [RFC][PATCH 00/14 v2] function_graph: Rewrite to allow multiple users

2019-05-22 Thread Masami Hiramatsu
On Mon, 20 May 2019 10:20:01 -0400 Steven Rostedt wrote: > > The background for this is explained in the V1 version found here: > > http://lkml.kernel.org/r/20181122012708.491151...@goodmis.org > > The TL;DR; is this: > > The function graph tracer required a rewrite, mainly because it > ca

[RFC][PATCH 00/14 v2] function_graph: Rewrite to allow multiple users

2019-05-20 Thread Steven Rostedt
The background for this is explained in the V1 version found here: http://lkml.kernel.org/r/20181122012708.491151...@goodmis.org The TL;DR; is this: The function graph tracer required a rewrite, mainly because it can only allow one callback registered at a time. The main motivation for thi