Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-30 Thread Masami Hiramatsu
On Thu, 29 Nov 2018 22:24:35 -0500 Steven Rostedt wrote: > On Fri, 30 Nov 2018 11:26:58 +0900 > Masami Hiramatsu wrote: > > > On Thu, 29 Nov 2018 11:46:52 -0500 > > Steven Rostedt wrote: > > > > > On Thu, 29 Nov 2018 23:29:27 +0900 > > > Masami Hiramatsu wrote: > > > > > > > > One way to

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-29 Thread Steven Rostedt
On Fri, 30 Nov 2018 11:26:58 +0900 Masami Hiramatsu wrote: > On Thu, 29 Nov 2018 11:46:52 -0500 > Steven Rostedt wrote: > > > On Thu, 29 Nov 2018 23:29:27 +0900 > > Masami Hiramatsu wrote: > > > > > > One way to solve this is to also have a counter array that gets updated > > > > every time

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-29 Thread Masami Hiramatsu
On Thu, 29 Nov 2018 11:46:52 -0500 Steven Rostedt wrote: > On Thu, 29 Nov 2018 23:29:27 +0900 > Masami Hiramatsu wrote: > > > > One way to solve this is to also have a counter array that gets updated > > > every time the index array gets updated. And save the counter to the > > > shadow stack i

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-29 Thread Steven Rostedt
On Thu, 29 Nov 2018 23:29:27 +0900 Masami Hiramatsu wrote: > > One way to solve this is to also have a counter array that gets updated > > every time the index array gets updated. And save the counter to the > > shadow stack index as well. This way, we only call the return if the > > counter on t

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-29 Thread Masami Hiramatsu
Hi Steve, On Mon, 26 Nov 2018 11:32:15 -0500 Steven Rostedt wrote: > On Mon, 26 Nov 2018 18:21:12 +0900 > Masami Hiramatsu wrote: > > > > > Note, if another fgraph_ops is registered in the same location, its > > > retfunc may be called that was set by a previous fgraph_ops. This > > > is not

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-26 Thread Steven Rostedt
On Mon, 26 Nov 2018 18:21:12 +0900 Masami Hiramatsu wrote: > > Note, if another fgraph_ops is registered in the same location, its > > retfunc may be called that was set by a previous fgraph_ops. This > > is not a regression because that's what can happen today if you unregister > > a callback f

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-26 Thread Masami Hiramatsu
Hi Steve, On Wed, 21 Nov 2018 20:27:08 -0500 Steven Rostedt wrote: > > I talked with many of you at Plumbers about rewriting the function graph > tracer. Well, this is it. I was originally going to produce just a > proof of concept, but when I found that I had to fix a design flaw > and that co

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-22 Thread Peter Zijlstra
On Thu, Nov 22, 2018 at 07:46:05AM -0500, Steven Rostedt wrote: > On Thu, 22 Nov 2018 11:08:12 +0100 > Peter Zijlstra wrote: > > > On Wed, Nov 21, 2018 at 08:27:08PM -0500, Steven Rostedt wrote: > > > Well the fuction graph tracer is arguably the strongest of the tracers. > > > It shows both the

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-22 Thread Steven Rostedt
On Thu, 22 Nov 2018 11:08:12 +0100 Peter Zijlstra wrote: > On Wed, Nov 21, 2018 at 08:27:08PM -0500, Steven Rostedt wrote: > > Well the fuction graph tracer is arguably the strongest of the tracers. > > It shows both the entrance and exit of a function, can give the timings > > of a function, and

Re: [RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-22 Thread Peter Zijlstra
On Wed, Nov 21, 2018 at 08:27:08PM -0500, Steven Rostedt wrote: > Well the fuction graph tracer is arguably the strongest of the tracers. > It shows both the entrance and exit of a function, can give the timings > of a function, and shows the execution of the code quite nicely. > > But it has one

[RFC][PATCH 00/14] function_graph: Rewrite to allow multiple users

2018-11-21 Thread Steven Rostedt
I talked with many of you at Plumbers about rewriting the function graph tracer. Well, this is it. I was originally going to produce just a proof of concept, but when I found that I had to fix a design flaw and that covered all the arch code anyway, I decided to do more of a RFC patch set. I pro