Re: [RFC][PATCH] make module refcounts use percpu_counters

2007-10-01 Thread Rusty Russell
On Mon, 2007-10-01 at 10:03 -0700, Dave Hansen wrote: > On Mon, 2007-10-01 at 19:43 +1000, Rusty Russell wrote: > > On Fri, 2007-09-28 at 16:00 -0700, Dave Hansen wrote: > > > Module refcounts currently use a percpu counter stored > > > in the 'struct module'. However, we also have a more > > > ge

Re: [RFC][PATCH] make module refcounts use percpu_counters

2007-10-01 Thread Dave Hansen
On Mon, 2007-10-01 at 19:43 +1000, Rusty Russell wrote: > On Fri, 2007-09-28 at 16:00 -0700, Dave Hansen wrote: > > Module refcounts currently use a percpu counter stored > > in the 'struct module'. However, we also have a more > > generic implementation that does stuff like handle > > hotplug cpu

Re: [RFC][PATCH] make module refcounts use percpu_counters

2007-10-01 Thread Rusty Russell
On Fri, 2007-09-28 at 16:00 -0700, Dave Hansen wrote: > Module refcounts currently use a percpu counter stored > in the 'struct module'. However, we also have a more > generic implementation that does stuff like handle > hotplug cpus. > > I'm not actually all that convinced that this refcount > a

[RFC][PATCH] make module refcounts use percpu_counters

2007-09-28 Thread Dave Hansen
Module refcounts currently use a percpu counter stored in the 'struct module'. However, we also have a more generic implementation that does stuff like handle hotplug cpus. I'm not actually all that convinced that this refcount actually does a lot of good, with cpus racing bumping the counters a