Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-16 Thread Seth Jennings
On Wed, Aug 14, 2013 at 12:40:43PM -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 14, 2013 at 02:31:45PM -0500, Seth Jennings wrote: > > Large memory systems (~1TB or more) experience boot delays on the order > > of minutes due to the initializing the memory configuration part of > > sysfs at /sys/

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-16 Thread Seth Jennings
On Thu, Aug 15, 2013 at 02:01:09AM +0200, Rafael J. Wysocki wrote: > On Wednesday, August 14, 2013 02:31:45 PM Seth Jennings wrote: > > Large memory systems (~1TB or more) experience boot delays on the order > > of minutes due to the initializing the memory configuration part of > > sysfs at /sys/d

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Michael Ellerman
On Wed, Aug 14, 2013 at 04:52:53PM -0500, Seth Jennings wrote: > On Wed, Aug 14, 2013 at 02:37:26PM -0700, Yinghai Lu wrote: > > On Wed, Aug 14, 2013 at 1:35 PM, Greg Kroah-Hartman > > wrote: > > > On Wed, Aug 14, 2013 at 01:05:33PM -0700, Dave Hansen wrote: > > >> On 08/14/2013 12:43 PM, Greg Kro

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Rafael J. Wysocki
On Wednesday, August 14, 2013 02:31:45 PM Seth Jennings wrote: > Large memory systems (~1TB or more) experience boot delays on the order > of minutes due to the initializing the memory configuration part of > sysfs at /sys/devices/system/memory/. > > ppc64 has a normal memory block size of 256M (h

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Yinghai Lu
On Wed, Aug 14, 2013 at 2:52 PM, Seth Jennings wrote: > On Wed, Aug 14, 2013 at 02:37:26PM -0700, Yinghai Lu wrote: > If I am understanding you correctly, you are suggesting we make the block size > a boot time tunable. It can't be a runtime tunable since the memory blocks > are > currently cre

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Seth Jennings
On Wed, Aug 14, 2013 at 02:37:26PM -0700, Yinghai Lu wrote: > On Wed, Aug 14, 2013 at 1:35 PM, Greg Kroah-Hartman > wrote: > > On Wed, Aug 14, 2013 at 01:05:33PM -0700, Dave Hansen wrote: > >> On 08/14/2013 12:43 PM, Greg Kroah-Hartman wrote: > >> > On Wed, Aug 14, 2013 at 02:31:45PM -0500, Seth J

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Dave Hansen
On 08/14/2013 02:37 PM, Cody P Schafer wrote: > Also, I'd expect userspace tools might use readdir() to find out what > memory blocks a system has (unless they just stat("memory0"), > stat("memory1")...). I don't think filesystem tricks (at least within > sysfs) are going to let this magically be s

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Yinghai Lu
On Wed, Aug 14, 2013 at 1:35 PM, Greg Kroah-Hartman wrote: > On Wed, Aug 14, 2013 at 01:05:33PM -0700, Dave Hansen wrote: >> On 08/14/2013 12:43 PM, Greg Kroah-Hartman wrote: >> > On Wed, Aug 14, 2013 at 02:31:45PM -0500, Seth Jennings wrote: >> >> ppc64 has a normal memory block size of 256M (how

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Cody P Schafer
On 08/14/2013 02:14 PM, Seth Jennings wrote: >An existing tool would not work >with this patch (plus boot option) since it would not know how to >show/hide things. It lets_part_ of those existing tools get reused >since they only have to be taught how to show/hide things. > >I'd find this reall

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Dave Hansen
On 08/14/2013 02:14 PM, Seth Jennings wrote: > On Wed, Aug 14, 2013 at 01:47:27PM -0700, Dave Hansen wrote: >> On 08/14/2013 12:31 PM, Seth Jennings wrote: >>> +static unsigned long *memblock_present; >>> +static bool largememory_enable __read_mostly; >> >> How would you see this getting used in pr

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Seth Jennings
On Wed, Aug 14, 2013 at 01:35:46PM -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 14, 2013 at 01:05:33PM -0700, Dave Hansen wrote: > > On 08/14/2013 12:43 PM, Greg Kroah-Hartman wrote: > > > On Wed, Aug 14, 2013 at 02:31:45PM -0500, Seth Jennings wrote: > > >> ppc64 has a normal memory block size o

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Seth Jennings
On Wed, Aug 14, 2013 at 01:47:27PM -0700, Dave Hansen wrote: > On 08/14/2013 12:31 PM, Seth Jennings wrote: > > There was a significant amount of refactoring to allow for this but > > IMHO, the code is much easier to understand now. > ... > > drivers/base/memory.c | 248 > > +

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Dave Hansen
On 08/14/2013 12:31 PM, Seth Jennings wrote: > There was a significant amount of refactoring to allow for this but > IMHO, the code is much easier to understand now. ... > drivers/base/memory.c | 248 > + > include/linux/memory.h | 1 - > 2 files

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Nathan Fontenot
On 08/14/2013 02:31 PM, Seth Jennings wrote: > Large memory systems (~1TB or more) experience boot delays on the order > of minutes due to the initializing the memory configuration part of > sysfs at /sys/devices/system/memory/. With the previous work that has been done in the memory sysfs layout

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Greg Kroah-Hartman
On Wed, Aug 14, 2013 at 01:05:33PM -0700, Dave Hansen wrote: > On 08/14/2013 12:43 PM, Greg Kroah-Hartman wrote: > > On Wed, Aug 14, 2013 at 02:31:45PM -0500, Seth Jennings wrote: > >> ppc64 has a normal memory block size of 256M (however sometimes as low > >> as 16M depending on the system LMB siz

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Dave Hansen
On 08/14/2013 12:43 PM, Greg Kroah-Hartman wrote: > On Wed, Aug 14, 2013 at 02:31:45PM -0500, Seth Jennings wrote: >> ppc64 has a normal memory block size of 256M (however sometimes as low >> as 16M depending on the system LMB size), and (I think) x86 is 128M. With >> 1TB of RAM and a 256M block s

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Greg Kroah-Hartman
On Wed, Aug 14, 2013 at 02:31:45PM -0500, Seth Jennings wrote: > Large memory systems (~1TB or more) experience boot delays on the order > of minutes due to the initializing the memory configuration part of > sysfs at /sys/devices/system/memory/. Are you sure that is the problem area? Have you ru

Re: [RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Greg Kroah-Hartman
On Wed, Aug 14, 2013 at 02:31:45PM -0500, Seth Jennings wrote: > Large memory systems (~1TB or more) experience boot delays on the order > of minutes due to the initializing the memory configuration part of > sysfs at /sys/devices/system/memory/. > > ppc64 has a normal memory block size of 256M (h

[RFC][PATCH] drivers: base: dynamic memory block creation

2013-08-14 Thread Seth Jennings
Large memory systems (~1TB or more) experience boot delays on the order of minutes due to the initializing the memory configuration part of sysfs at /sys/devices/system/memory/. ppc64 has a normal memory block size of 256M (however sometimes as low as 16M depending on the system LMB size), and (I