Re: [RFC][Intel-IOMMU] Fix for IOMMU early crash

2007-09-10 Thread Keshavamurthy, Anil S
On Mon, Sep 10, 2007 at 11:25:43PM +0300, Muli Ben-Yehuda wrote: > On Tue, Sep 11, 2007 at 10:42:31AM -0700, Keshavamurthy, Anil S wrote: > > > Yes, I agree that pci_dev->sysdata can;t be removed. Even we (IOMMU) > > were dependent on this field but somehow this field is being > > overwritten to p

Re: [RFC][Intel-IOMMU] Fix for IOMMU early crash

2007-09-10 Thread Muli Ben-Yehuda
On Tue, Sep 11, 2007 at 10:42:31AM -0700, Keshavamurthy, Anil S wrote: > Yes, I agree that pci_dev->sysdata can;t be removed. Even we (IOMMU) > were dependent on this field but somehow this field is being > overwritten to point to pci_bus's->sysdata and hence IOMMU was > failing. Earlier it was ov

Re: [RFC][Intel-IOMMU] Fix for IOMMU early crash

2007-09-10 Thread Keshavamurthy, Anil S
On Mon, Sep 10, 2007 at 03:37:48AM +1000, Paul Mackerras wrote: > Keshavamurthy, Anil S writes: > > > Subject: [RFC][Intel-IOMMU] Fix for IOMMU early crash > > > > Populating pci_bus->sysdata way early in the pci discovery phase > > sets NON-NULL value to

Re: [RFC][Intel-IOMMU] Fix for IOMMU early crash

2007-09-10 Thread Keshavamurthy, Anil S
rthy, Anil S wrote: > > > > > > > Subject: [RFC][Intel-IOMMU] Fix for IOMMU early crash > > > > > > This patch feels like a huge hack. See below. > > > > You seem to be jumping to conclusion without going in detail. The > > pci_dev struct contains pointer t

Re: [RFC][Intel-IOMMU] Fix for IOMMU early crash

2007-09-09 Thread Paul Mackerras
Keshavamurthy, Anil S writes: > Subject: [RFC][Intel-IOMMU] Fix for IOMMU early crash > > Populating pci_bus->sysdata way early in the pci discovery phase > sets NON-NULL value to pci_dev->sysdata which breaks the assumption > in the Intel IOMMU driver and crashes the s

Re: [RFC][Intel-IOMMU] Fix for IOMMU early crash

2007-09-09 Thread Muli Ben-Yehuda
On Mon, Sep 10, 2007 at 08:43:59AM -0700, Keshavamurthy, Anil S wrote: > On Sun, Sep 09, 2007 at 02:16:19PM +0300, Muli Ben-Yehuda wrote: > > On Sat, Sep 08, 2007 at 01:05:24PM -0700, Keshavamurthy, Anil S wrote: > > > > > Subject: [RFC][Intel-IOMMU] Fix for IOMMU early c

Re: [RFC][Intel-IOMMU] Fix for IOMMU early crash

2007-09-09 Thread Keshavamurthy, Anil S
On Sun, Sep 09, 2007 at 02:16:19PM +0300, Muli Ben-Yehuda wrote: > On Sat, Sep 08, 2007 at 01:05:24PM -0700, Keshavamurthy, Anil S wrote: > > > Subject: [RFC][Intel-IOMMU] Fix for IOMMU early crash > > This patch feels like a huge hack. See below. You seem to be jumping to

Re: [RFC][Intel-IOMMU] Fix for IOMMU early crash

2007-09-09 Thread Muli Ben-Yehuda
On Sat, Sep 08, 2007 at 01:05:24PM -0700, Keshavamurthy, Anil S wrote: > Subject: [RFC][Intel-IOMMU] Fix for IOMMU early crash This patch feels like a huge hack. See below. > This patch removes sysdata from pci_dev struct and creates a new > field called sys_data which is exclusivel

[RFC][Intel-IOMMU] Fix for IOMMU early crash

2007-09-07 Thread Keshavamurthy, Anil S
Subject: [RFC][Intel-IOMMU] Fix for IOMMU early crash Populating pci_bus->sysdata way early in the pci discovery phase sets NON-NULL value to pci_dev->sysdata which breaks the assumption in the Intel IOMMU driver and crashes the system. In the drivers/pci/probe.c, pci_dev->sysdata ge