Re: [RFC/PATCH] perf: Add sizeof operator support

2017-05-02 Thread Jeremy Linton
On 04/30/2017 05:06 PM, Jon Masters wrote: Hi Jeremy, On 06/14/2016 12:38 PM, Jeremy Linton wrote: There are a fair number of tracepoints in the kernel making use of the sizeof operator. Allow perf to understand some of those cases, and report a more informative error message for the ones it c

Re: [RFC/PATCH] perf: Add sizeof operator support

2017-04-30 Thread Jon Masters
Hi Jeremy, On 06/14/2016 12:38 PM, Jeremy Linton wrote: > There are a fair number of tracepoints in the kernel making > use of the sizeof operator. Allow perf to understand some of > those cases, and report a more informative error message for > the ones it cannot understand. What's the status o

Re: [RFC/PATCH] perf: Add sizeof operator support

2016-06-19 Thread Namhyung Kim
On Fri, Jun 17, 2016 at 03:08:27PM -0400, Steven Rostedt wrote: > On Fri, 17 Jun 2016 13:57:44 -0500 > Jeremy Linton wrote: > > > > That is the simple case, initially I was going to just hand code some of > > the sizeofs in the kernel, but then I started noticing more complex > > cases, and wh

Re: [RFC/PATCH] perf: Add sizeof operator support

2016-06-17 Thread Steven Rostedt
On Fri, 17 Jun 2016 13:57:44 -0500 Jeremy Linton wrote: > That is the simple case, initially I was going to just hand code some of > the sizeofs in the kernel, but then I started noticing more complex > cases, and why I RFCed this patch. > > For example, on x64/xen there are fair number with

Re: [RFC/PATCH] perf: Add sizeof operator support

2016-06-17 Thread Jeremy Linton
On 06/17/2016 11:50 AM, Steven Rostedt wrote: On Fri, 17 Jun 2016 11:32:08 -0500 Jeremy Linton wrote: + + if (strcmp(token, "__u64") == 0) { + if (asprintf(&arg->atom.atom, "%zd", sizeof(__u64)) < 0) + goto out_free_atom; + } else if (strcmp(tok

Re: [RFC/PATCH] perf: Add sizeof operator support

2016-06-17 Thread Steven Rostedt
On Fri, 17 Jun 2016 11:32:08 -0500 Jeremy Linton wrote: > >> + > >> + if (strcmp(token, "__u64") == 0) { > >> + if (asprintf(&arg->atom.atom, "%zd", sizeof(__u64)) < 0) > >> + goto out_free_atom; > >> + } else if (strcmp(token, "__u32") == 0) { > >> + if (asp

Re: [RFC/PATCH] perf: Add sizeof operator support

2016-06-17 Thread Jeremy Linton
Hi Steven, On 06/17/2016 11:17 AM, Steven Rostedt wrote: On Tue, 14 Jun 2016 11:38:32 -0500 Jeremy Linton wrote: There are a fair number of tracepoints in the kernel making use of the sizeof operator. Allow perf to understand some of those cases, and report a more informative error message fo

Re: [RFC/PATCH] perf: Add sizeof operator support

2016-06-17 Thread Steven Rostedt
On Tue, 14 Jun 2016 11:38:32 -0500 Jeremy Linton wrote: > There are a fair number of tracepoints in the kernel making > use of the sizeof operator. Allow perf to understand some of > those cases, and report a more informative error message for > the ones it cannot understand. > > Signed-off-by:

[RFC/PATCH] perf: Add sizeof operator support

2016-06-14 Thread Jeremy Linton
There are a fair number of tracepoints in the kernel making use of the sizeof operator. Allow perf to understand some of those cases, and report a more informative error message for the ones it cannot understand. Signed-off-by: Jeremy Linton --- So this is as much a RFC as a patch because the us