Re: [REVIEW][PATCH 08/22] signal/mips: Use force_sig_fault where appropriate

2018-05-10 Thread Eric W. Biederman
Matt Redfearn writes: > Hi Eric, > > On 10/05/18 03:39, Eric W. Biederman wrote: >> Matt Redfearn writes: >> >>> Hi Eric, >>> >>> On 20/04/18 15:37, Eric W. Biederman wrote: Filling in struct siginfo before calling force_sig_info a tedious and error prone process, where once in a great

Re: [REVIEW][PATCH 08/22] signal/mips: Use force_sig_fault where appropriate

2018-05-10 Thread Matt Redfearn
Hi Eric, On 10/05/18 03:39, Eric W. Biederman wrote: Matt Redfearn writes: Hi Eric, On 20/04/18 15:37, Eric W. Biederman wrote: Filling in struct siginfo before calling force_sig_info a tedious and error prone process, where once in a great while the wrong fields are filled out, and siginfo

Re: [REVIEW][PATCH 08/22] signal/mips: Use force_sig_fault where appropriate

2018-05-09 Thread Eric W. Biederman
Matt Redfearn writes: > Hi Eric, > > On 20/04/18 15:37, Eric W. Biederman wrote: >> Filling in struct siginfo before calling force_sig_info a tedious and >> error prone process, where once in a great while the wrong fields >> are filled out, and siginfo has been inconsistently cleared. >> >> Simp

Re: [REVIEW][PATCH 08/22] signal/mips: Use force_sig_fault where appropriate

2018-05-09 Thread Matt Redfearn
Hi Eric, On 20/04/18 15:37, Eric W. Biederman wrote: Filling in struct siginfo before calling force_sig_info a tedious and error prone process, where once in a great while the wrong fields are filled out, and siginfo has been inconsistently cleared. Simplify this process by using the helper for

[REVIEW][PATCH 08/22] signal/mips: Use force_sig_fault where appropriate

2018-04-20 Thread Eric W. Biederman
Filling in struct siginfo before calling force_sig_info a tedious and error prone process, where once in a great while the wrong fields are filled out, and siginfo has been inconsistently cleared. Simplify this process by using the helper force_sig_fault. Which takes as a parameters all of the in