Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure

2014-11-19 Thread Mark Brown
On Wed, Nov 19, 2014 at 04:39:54PM +0900, Gyungoh Yoo wrote: > If of_match and regulators_node are assigned, don't I need to > call of_regulator_match()? Does regulator_register() call it internally? > So can I write code like below? > > static const struct regulator_desc sky81452_reg = { >

Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure

2014-11-18 Thread Gyungoh Yoo
On Tue, Nov 18, 2014 at 11:20:56AM +, Mark Brown wrote: > On Tue, Nov 18, 2014 at 05:04:51PM +0900, Gyungoh Yoo wrote: > > On Mon, Nov 17, 2014 at 02:18:36PM +, Mark Brown wrote: > > > > Don't open code this, use regulators_node and of_match as previously > > > advised. > > > I think I ha

Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure

2014-11-18 Thread Mark Brown
On Tue, Nov 18, 2014 at 05:04:51PM +0900, Gyungoh Yoo wrote: > On Mon, Nov 17, 2014 at 02:18:36PM +, Mark Brown wrote: > > Don't open code this, use regulators_node and of_match as previously > > advised. > I think I had a misunderstanding. > But I have no idea about regulators_node and of_ma

Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure

2014-11-18 Thread Gyungoh Yoo
On Mon, Nov 17, 2014 at 02:18:36PM +, Mark Brown wrote: > On Mon, Nov 17, 2014 at 05:33:08PM +0900, gyun...@gmail.com wrote: > > > np = of_get_child_by_name(dev->parent->of_node, "regulator"); > > > + ret = of_regulator_match(dev, np, &sky81452_match, 1); > > Don't open code this, use

Re: [RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure

2014-11-17 Thread Mark Brown
On Mon, Nov 17, 2014 at 05:33:08PM +0900, gyun...@gmail.com wrote: > np = of_get_child_by_name(dev->parent->of_node, "regulator"); > + ret = of_regulator_match(dev, np, &sky81452_match, 1); Don't open code this, use regulators_node and of_match as previously advised. signature.asc De

[RESUBMIT PATCH v7 7/9] regulator: sky81452: Modify Device Tree structure

2014-11-17 Thread gyungoh
From: Gyungoh Yoo Signed-off-by: Gyungoh Yoo --- Changes v7: Modified licensing text to GPLv2 Splitted Kconfig renaming from DT patch Changes v6: Added new line character at the end of line of dev_err() Changes v5: Changed DT for regulator : 'lout' node should be defined under 'regulator' Remo