Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-05 Thread Andrew Morton
On Fri, 05 Dec 2014 15:54:15 +0100 Stefan Agner wrote: > It can be fixed, with something like this: > > @@ -346,7 +347,10 @@ static int snvs_rtc_resume(struct device *dev) > } > #endif > > -static SIMPLE_DEV_PM_OPS(snvs_rtc_pm_ops, snvs_rtc_suspend, > snvs_rtc_resume); > +static const struct

Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-05 Thread Stefan Agner
On 2014-12-05 01:12, Andrew Morton wrote: > On Wed, 3 Dec 2014 11:28:55 +0530 Sanchayan Maity > wrote: > >> This patch adds clock enable and disable support for >> the SNVS peripheral, which is required for using the >> RTC within the SNVS block. >> >> The clock is not strictly enforced, as this

Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-04 Thread Andrew Morton
On Wed, 3 Dec 2014 11:28:55 +0530 Sanchayan Maity wrote: > This patch adds clock enable and disable support for > the SNVS peripheral, which is required for using the > RTC within the SNVS block. > > The clock is not strictly enforced, as this would > break the i.MX devices. The clocking for t

Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-04 Thread Alessandro Zummo
On Thu, 04 Dec 2014 13:29:58 +0100 Stefan Agner wrote: > > Acked-by: Alessandro Zummo > > Through which tree is this going upstream? Andrew usually picks up those small patches, unless there's a more appropriate tree. -- Best regards, Alessandro Zummo, Tower Technologies - Torin

Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-04 Thread Stefan Agner
On 2014-12-04 11:05, Alessandro Zummo wrote: > On Wed, 3 Dec 2014 11:28:55 +0530 > Sanchayan Maity wrote: > >> The clock is not strictly enforced, as this would >> break the i.MX devices. The clocking for the i.MX >> devices seems to be enabled elsewhere and enabling >> RTC SNVS for Vybrid resul

Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-04 Thread Alessandro Zummo
On Wed, 3 Dec 2014 11:28:55 +0530 Sanchayan Maity wrote: > The clock is not strictly enforced, as this would > break the i.MX devices. The clocking for the i.MX > devices seems to be enabled elsewhere and enabling > RTC SNVS for Vybrid results in a crash. This patch > adds the clock support but

Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-04 Thread Stefan Agner
On 2014-12-03 06:58, Sanchayan Maity wrote: > This patch adds clock enable and disable support for > the SNVS peripheral, which is required for using the > RTC within the SNVS block. > > The clock is not strictly enforced, as this would > break the i.MX devices. The clocking for the i.MX > devices

[RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-02 Thread Sanchayan Maity
This patch adds clock enable and disable support for the SNVS peripheral, which is required for using the RTC within the SNVS block. The clock is not strictly enforced, as this would break the i.MX devices. The clocking for the i.MX devices seems to be enabled elsewhere and enabling RTC SNVS for V