Re: [RESEND PATCH v2 04/15] ASoC: qcom: qdsp6: Add support to Q6AFE

2018-01-03 Thread Srinivas Kandagatla
Thanks for the comments! On 02/01/18 00:45, Bjorn Andersson wrote: On Thu 14 Dec 09:33 PST 2017, srinivas.kandaga...@linaro.org wrote: [..] + +config SND_SOC_QDSP6_AFE + tristate + default n Do you see a particular benefit of having one kernel module per function? Why not just co

Re: [RESEND PATCH v2 04/15] ASoC: qcom: qdsp6: Add support to Q6AFE

2018-01-01 Thread Bjorn Andersson
On Thu 14 Dec 09:33 PST 2017, srinivas.kandaga...@linaro.org wrote: [..] > + > +config SND_SOC_QDSP6_AFE > + tristate > + default n Do you see a particular benefit of having one kernel module per function? Why not just compile them all into the same q6dsp.ko? > + > +config SND_SOC_QDSP6

[RESEND PATCH v2 04/15] ASoC: qcom: qdsp6: Add support to Q6AFE

2017-12-14 Thread srinivas . kandagatla
From: Srinivas Kandagatla This patch adds support to q6 AFE (Audio Front End) module on Q6DSP. AFE module sits right at the other end of cpu where the codec/audio devices are connected. AFE provides abstraced interfaces to both hardware and virtual devices. Each AFE tx/rx port can be configured