Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf

2017-08-30 Thread Fabrice Gasnier
On 08/30/2017 05:02 PM, Mark Brown wrote: > On Wed, Aug 30, 2017 at 11:11:24AM +0200, Fabrice Gasnier wrote: >> On 08/29/2017 08:57 PM, Mark Brown wrote: >>> On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote: > +static int __init stm32_vrefbuf_init(void) +{ + return

Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf

2017-08-30 Thread Mark Brown
On Wed, Aug 30, 2017 at 11:11:24AM +0200, Fabrice Gasnier wrote: > On 08/29/2017 08:57 PM, Mark Brown wrote: > > On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote: > >> +static int __init stm32_vrefbuf_init(void) > >> +{ > >> + return platform_driver_register(&stm32_vrefbuf_driver);

Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf

2017-08-30 Thread Fabrice Gasnier
On 08/29/2017 08:57 PM, Mark Brown wrote: > On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote: > >> +ret = clk_prepare_enable(priv->clk); >> +if (ret) { >> +dev_err(&pdev->dev, "clk prepare failed\n"); > > If you're printing an error include the error code, it'll

Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf

2017-08-29 Thread Mark Brown
On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote: > + ret = clk_prepare_enable(priv->clk); > + if (ret) { > + dev_err(&pdev->dev, "clk prepare failed\n"); If you're printing an error include the error code, it'll help users figure out what went wrong. > + d

[RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf

2017-08-28 Thread Fabrice Gasnier
Add regulator driver for STM32 voltage reference buffer which can be used as voltage reference for ADCs, DACs and external components through dedicated VREF+ pin. Signed-off-by: Fabrice Gasnier --- drivers/regulator/Kconfig | 12 +++ drivers/regulator/Makefile| 1 + drivers/re