Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Konrad Rzeszutek Wilk
On July 11, 2015 7:23:38 AM EDT, Christoph Hellwig wrote: >On Sat, Jul 11, 2015 at 07:17:18AM -0400, Konrad Rzeszutek Wilk wrote: >> The 'locked' parameter can be used to tell the function to not take >the lock. >> >> But it would drop the lock in both cases. > >Konrad, > >no conditional locking

Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Christoph Hellwig
On Sat, Jul 11, 2015 at 07:17:18AM -0400, Konrad Rzeszutek Wilk wrote: > The 'locked' parameter can be used to tell the function to not take the lock. > > But it would drop the lock in both cases. Konrad, no conditional locking please. Split the functionality up in multiple functions if you may

Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Konrad Rzeszutek Wilk
On July 11, 2015 4:18:42 AM EDT, Bob Liu wrote: > >On 07/11/2015 03:57 AM, Konrad Rzeszutek Wilk wrote: >> On Mon, Jul 06, 2015 at 05:56:48PM +0800, Bob Liu wrote: >>> From: Arianna Avanzini >>> >>> This patch converts xen-blkfront driver to use the block multiqueue >APIs. >>> Only one hardware q

Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
On 07/11/2015 03:57 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 06, 2015 at 05:56:48PM +0800, Bob Liu wrote: >> From: Arianna Avanzini >> >> This patch converts xen-blkfront driver to use the block multiqueue APIs. >> Only one hardware queue is used now, so there is no performance change. >> >

Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 06, 2015 at 05:56:48PM +0800, Bob Liu wrote: > From: Arianna Avanzini > > This patch converts xen-blkfront driver to use the block multiqueue APIs. > Only one hardware queue is used now, so there is no performance change. > > The legacy non-mq code was deleted completely which is the

[RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-06 Thread Bob Liu
From: Arianna Avanzini This patch converts xen-blkfront driver to use the block multiqueue APIs. Only one hardware queue is used now, so there is no performance change. The legacy non-mq code was deleted completely which is the same as other drivers like virtio, mtip, and nvme. Also dropped unn