Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-03-10 Thread Rohit Jain
Hi Peter, On 02/09/2018 04:53 AM, Peter Zijlstra wrote: this_sd = rcu_dereference(*this_cpu_ptr(&sd_llc)); if (!this_sd) @@ -6173,8 +6183,15 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, int t return -1;

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-14 Thread Dietmar Eggemann
On 02/09/2018 11:05 PM, Rohit Jain wrote: On 02/09/2018 07:46 AM, Dietmar Eggemann wrote: On 02/09/2018 01:53 PM, Peter Zijlstra wrote: On Mon, Jan 29, 2018 at 03:27:09PM -0800, Rohit Jain wrote: [...] @@ -6173,8 +6183,15 @@ static int select_idle_cpu(struct task_struct *p, struct sched_do

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-09 Thread Rohit Jain
On 02/09/2018 04:53 AM, Peter Zijlstra wrote: On Mon, Jan 29, 2018 at 03:27:09PM -0800, Rohit Jain wrote: diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 26a71eb..ce5ccf8 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5625,6 +5625,11 @@ static unsigned long capacit

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-09 Thread Rohit Jain
On 02/09/2018 07:46 AM, Dietmar Eggemann wrote: On 02/09/2018 01:53 PM, Peter Zijlstra wrote: On Mon, Jan 29, 2018 at 03:27:09PM -0800, Rohit Jain wrote: [...] @@ -6173,8 +6183,15 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, int t   return -1;

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-09 Thread Dietmar Eggemann
On 02/09/2018 01:53 PM, Peter Zijlstra wrote: On Mon, Jan 29, 2018 at 03:27:09PM -0800, Rohit Jain wrote: [...] @@ -6173,8 +6183,15 @@ static int select_idle_cpu(struct task_struct *p, struct sched_domain *sd, int t return -1; if (!cpumask_test_cpu(cpu

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-09 Thread Peter Zijlstra
On Mon, Jan 29, 2018 at 03:27:09PM -0800, Rohit Jain wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 26a71eb..ce5ccf8 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -5625,6 +5625,11 @@ static unsigned long capacity_orig_of(int cpu) > return cpu_rq(

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-09 Thread Peter Zijlstra
On Mon, Feb 05, 2018 at 10:50:41PM -0800, Joel Fernandes wrote: > That's Ok with me. Just that I remember Peter messing with this path > and that it was expensive to scan too much for some systems. The other > thing is you're really doing to do a "fail safe" as you call it search > here with SIS_P

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-09 Thread Peter Zijlstra
On Mon, Jan 29, 2018 at 07:39:15PM -0800, Joel Fernandes wrote: > > @@ -6081,7 +6086,7 @@ static int select_idle_core(struct task_struct *p, > > struct sched_domain *sd, int > > > > for_each_cpu(cpu, cpu_smt_mask(core)) { > > cpumask_clear_cpu(cpu, cpus); >

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-06 Thread Rohit Jain
On 02/05/2018 10:50 PM, Joel Fernandes wrote: On Wed, Jan 31, 2018 at 9:50 AM, Rohit Jain wrote: kernel/sched/fair.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 26a71eb..ce5

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-06 Thread Rohit Jain
On 02/05/2018 10:42 PM, Joel Fernandes wrote: On Tue, Jan 30, 2018 at 11:47 AM, Rohit Jain wrote: [...] @@ -6102,7 +6107,8 @@ static int select_idle_core(struct task_struct *p, struct sched_domain *sd, int */ static int select_idle_smt(struct task_struct *p, struct sched_domain *sd, in

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-05 Thread Joel Fernandes
On Mon, Feb 5, 2018 at 10:50 PM, Joel Fernandes wrote: > On Wed, Jan 31, 2018 at 9:50 AM, Rohit Jain wrote: >>kernel/sched/fair.c | 38 -- >>1 file changed, 28 insertions(+), 10 deletions(-) >> >> diff --git a/kernel/sched/fair.c b/kernel

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-05 Thread Joel Fernandes
On Wed, Jan 31, 2018 at 9:50 AM, Rohit Jain wrote: >kernel/sched/fair.c | 38 -- >1 file changed, 28 insertions(+), 10 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 26a71eb..ce5ccf8 100644 > --- a/

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-02-05 Thread Joel Fernandes
On Tue, Jan 30, 2018 at 11:47 AM, Rohit Jain wrote: [...] >>> @@ -6102,7 +6107,8 @@ static int select_idle_core(struct task_struct *p, >>> struct sched_domain *sd, int >>>*/ >>> static int select_idle_smt(struct task_struct *p, struct sched_domain >>> *sd, int target) >>> { >>> - int

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-01-31 Thread Rohit Jain
On 01/30/2018 05:57 PM, Joel Fernandes wrote: Signed-off-by: Rohit Jain --- kernel/sched/fair.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 26a71eb..ce5ccf8 100644 --- a/kernel/

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-01-30 Thread Joel Fernandes
On Tue, Jan 30, 2018 at 11:47 AM, Rohit Jain wrote: [...] >>> >>> Currently fast path in the scheduler looks for an idle CPU to schedule >>> threads on. Capacity is taken into account in the function >>> 'select_task_rq_fair' when it calls 'wake_cap', however it ignores the >>> instantaneous capac

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-01-30 Thread Rohit Jain
Hi Joel, On 1/29/2018 7:39 PM, Joel Fernandes wrote: Hi Rohit, On Mon, Jan 29, 2018 at 3:27 PM, Rohit Jain wrote: Currently fast path in the scheduler looks for an idle CPU to schedule threads on. Capacity is taken into account in the function 'select_task_rq_fair' when it calls 'wake_cap', h

Re: [RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-01-29 Thread Joel Fernandes
Hi Rohit, On Mon, Jan 29, 2018 at 3:27 PM, Rohit Jain wrote: > Currently fast path in the scheduler looks for an idle CPU to schedule > threads on. Capacity is taken into account in the function > 'select_task_rq_fair' when it calls 'wake_cap', however it ignores the > instantaneous capacity and

[RESEND PATCH] sched/fair: consider RT/IRQ pressure in select_idle_sibling

2018-01-29 Thread Rohit Jain
Currently fast path in the scheduler looks for an idle CPU to schedule threads on. Capacity is taken into account in the function 'select_task_rq_fair' when it calls 'wake_cap', however it ignores the instantaneous capacity and looks at the original capacity. Furthermore select_idle_sibling path o