Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-10-15 Thread Christian Borntraeger
Am Montag, 10. September 2007 schrieb Laurent Vivier: > The aim of these four patches is to introduce Virtual Machine time accounting. I would move this line    if (p->flags & PF_VCPU) {    account_guest_time(p, cputime); -->   p->flags &= ~PF_VCPU; <-    

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-11 Thread Rik van Riel
Laurent Vivier wrote: And as values are read with a sscanf() by procps, I think adding a field at the end of the line is not a problem. It's not. At the time iowait was introduced I verified this in procps. -- All Rights Reversed - To unsubscribe from this list: send the line "unsubscribe l

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-11 Thread Rik van Riel
Ingo Molnar wrote: * Laurent Vivier <[EMAIL PROTECTED]> wrote: This new version remove conditional compilation on GUEST_ACCOUNTING. excellent! For all 4 patches: Acked-by: Ingo Molnar <[EMAIL PROTECTED]> i'd suggest inclusion into 2.6.24. can the /proc change break anything? Any old procp

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-11 Thread Laurent Vivier
Ingo Molnar wrote: > * Laurent Vivier <[EMAIL PROTECTED]> wrote: > >> This new version remove conditional compilation on GUEST_ACCOUNTING. > > excellent! For all 4 patches: > > Acked-by: Ingo Molnar <[EMAIL PROTECTED]> > > i'd suggest inclusion into 2.6.24. Thank you. > can the /proc change

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Ingo Molnar
* Laurent Vivier <[EMAIL PROTECTED]> wrote: > This new version remove conditional compilation on GUEST_ACCOUNTING. excellent! For all 4 patches: Acked-by: Ingo Molnar <[EMAIL PROTECTED]> i'd suggest inclusion into 2.6.24. can the /proc change break anything? Any old procps version perhaps?

Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Rik van Riel
Laurent Vivier wrote: The aim of these four patches is to introduce Virtual Machine time accounting. Signed-off-by: Laurent Vivier <[EMAIL PROTECTED]> Acked-by: Rik van Riel <[EMAIL PROTECTED]> -- Politics is the struggle between those who want to make their country the best in the world,

[RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

2007-09-10 Thread Laurent Vivier
This new version remove conditional compilation on GUEST_ACCOUNTING. -- The aim of these four patches is to introduce Virtual Machine time accounting. [PATCH 1/4] as recent CPUs introduce a third running state, after "user" and "system", we need a new field, "guest", in cpustat to store