Re: [RESEND] spi/tegra114: Correct support for cs_change

2013-09-24 Thread Rhyland Klein
On 9/23/2013 7:08 PM, Trent Piepho wrote: > On Mon, Sep 23, 2013 at 2:14 PM, Stephen Warren wrote: >> >> That sounds broken. Normally, shouldn't CS assert before a transaction, >> stay asserted during a transaction, then deassert after the transaction? >> It shouldn't rise and fall very quickly in

Re: [RESEND] spi/tegra114: Correct support for cs_change

2013-09-23 Thread Trent Piepho
On Mon, Sep 23, 2013 at 2:14 PM, Stephen Warren wrote: > > That sounds broken. Normally, shouldn't CS assert before a transaction, > stay asserted during a transaction, then deassert after the transaction? > It shouldn't rise and fall very quickly in between parts of the transaction. That is norm

Re: [RESEND] spi/tegra114: Correct support for cs_change

2013-09-23 Thread Simon Glass
[trying again] Hi, On Mon, Sep 23, 2013 at 3:14 PM, Stephen Warren wrote: > On 09/23/2013 03:01 PM, Rhyland Klein wrote: >> On 9/23/2013 3:58 PM, Stephen Warren wrote: >>> On 09/23/2013 01:48 PM, Rhyland Klein wrote: On 9/23/2013 2:51 PM, Stephen Warren wrote: > On 09/18/2013 12:17 PM,

Re: [RESEND] spi/tegra114: Correct support for cs_change

2013-09-23 Thread Stephen Warren
On 09/23/2013 03:01 PM, Rhyland Klein wrote: > On 9/23/2013 3:58 PM, Stephen Warren wrote: >> On 09/23/2013 01:48 PM, Rhyland Klein wrote: >>> On 9/23/2013 2:51 PM, Stephen Warren wrote: On 09/18/2013 12:17 PM, Rhyland Klein wrote: > The tegra114 driver wasn't currently handling the cs_cha

Re: [RESEND] spi/tegra114: Correct support for cs_change

2013-09-23 Thread Rhyland Klein
On 9/23/2013 3:58 PM, Stephen Warren wrote: > On 09/23/2013 01:48 PM, Rhyland Klein wrote: >> On 9/23/2013 2:51 PM, Stephen Warren wrote: >>> On 09/18/2013 12:17 PM, Rhyland Klein wrote: The tegra114 driver wasn't currently handling the cs_change functionality. It is meant to invert norma

Re: [RESEND] spi/tegra114: Correct support for cs_change

2013-09-23 Thread Stephen Warren
On 09/23/2013 01:48 PM, Rhyland Klein wrote: > On 9/23/2013 2:51 PM, Stephen Warren wrote: >> On 09/18/2013 12:17 PM, Rhyland Klein wrote: >>> The tegra114 driver wasn't currently handling the cs_change functionality. >>> It is meant to invert normal behavior, and we were only using it to possibly

Re: [RESEND] spi/tegra114: Correct support for cs_change

2013-09-23 Thread Rhyland Klein
On 9/23/2013 2:51 PM, Stephen Warren wrote: > On 09/18/2013 12:17 PM, Rhyland Klein wrote: >> The tegra114 driver wasn't currently handling the cs_change functionality. >> It is meant to invert normal behavior, and we were only using it to possibly >> delay at the end of a transfer. > > I don't re

Re: [RESEND] spi/tegra114: Correct support for cs_change

2013-09-23 Thread Stephen Warren
On 09/18/2013 12:17 PM, Rhyland Klein wrote: > The tegra114 driver wasn't currently handling the cs_change functionality. > It is meant to invert normal behavior, and we were only using it to possibly > delay at the end of a transfer. I don't really follow this patch description well. It may help

[RESEND] spi/tegra114: Correct support for cs_change

2013-09-18 Thread Rhyland Klein
The tegra114 driver wasn't currently handling the cs_change functionality. It is meant to invert normal behavior, and we were only using it to possibly delay at the end of a transfer. This patch modifies the logic so that the cs state will be toggled after every individual transfer or NOT toggled