RE: [Patch v4] cifs: Allocate validate negotiation request through kmalloc

2018-04-20 Thread Long Li
> Subject: Re: [Patch v4] cifs: Allocate validate negotiation request through > kmalloc > > On 4/20/2018 2:41 PM, Long Li wrote: > >> Subject: Re: [Patch v4] cifs: Allocate validate negotiation request > >> through kmalloc > >> > >> Looks good

Re: [Patch v4] cifs: Allocate validate negotiation request through kmalloc

2018-04-20 Thread Tom Talpey
On 4/20/2018 2:41 PM, Long Li wrote: Subject: Re: [Patch v4] cifs: Allocate validate negotiation request through kmalloc Looks good, but I have two possibly style-related comments. On 4/19/2018 5:38 PM, Long Li wrote: From: Long Li The data buffer allocated on the stack can't be D

RE: [Patch v4] cifs: Allocate validate negotiation request through kmalloc

2018-04-20 Thread Long Li
> Subject: Re: [Patch v4] cifs: Allocate validate negotiation request through > kmalloc > > Looks good, but I have two possibly style-related comments. > > On 4/19/2018 5:38 PM, Long Li wrote: > > From: Long Li > > > > The data buffer allocated on the stack

Re: [Patch v4] cifs: Allocate validate negotiation request through kmalloc

2018-04-20 Thread Pavel Shilovsky
2018-04-20 7:55 GMT-07:00 Tom Talpey : > Looks good, but I have two possibly style-related comments. > > > On 4/19/2018 5:38 PM, Long Li wrote: >> >> From: Long Li >> >> The data buffer allocated on the stack can't be DMA'ed, ib_dma_map_page >> will >> return an invalid DMA address for a buffer on

Re: [Patch v4] cifs: Allocate validate negotiation request through kmalloc

2018-04-20 Thread Tom Talpey
Looks good, but I have two possibly style-related comments. On 4/19/2018 5:38 PM, Long Li wrote: From: Long Li The data buffer allocated on the stack can't be DMA'ed, ib_dma_map_page will return an invalid DMA address for a buffer on stack. Even worse, this incorrect address can't be detected

[Patch v4] cifs: Allocate validate negotiation request through kmalloc

2018-04-19 Thread Long Li
From: Long Li The data buffer allocated on the stack can't be DMA'ed, ib_dma_map_page will return an invalid DMA address for a buffer on stack. Even worse, this incorrect address can't be detected by ib_dma_mapping_error. Sending data from this address to hardware will not fail, but the remote pe