Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-29 Thread Rik van Riel
On 05/27/2013 06:25 PM, Eric Dumazet wrote: On Mon, 2013-05-27 at 13:39 -0400, Rik van Riel wrote: Yes please. Getting memory management bug reports for dropped network packets got old years ago. Lets get rid of those messages. I am only wondering why this path has anything needing special

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Rik van Riel
On 05/28/2013 12:29 PM, Eric Dumazet wrote: On Tue, 2013-05-28 at 13:15 -0300, Rafael Aquini wrote: The real problem seems to be that more and more the network stack (drivers, perhaps) is relying on chunks of contiguous page-blocks without a fallback mechanism to order-0 page allocations. When

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Rik van Riel
On 05/27/2013 06:41 PM, Francois Romieu wrote: atom...@redhat.com : [...] Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a kernel backtrace. These warnings are harmless, but

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Joe Perches
On Tue, 2013-05-28 at 09:29 -0700, Eric Dumazet wrote: > I would bump nopage_rs to somethin more reasonable, like one hour or one > day. Reasonable is harder to specify but perhaps it could be made runtime configurable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Eric Dumazet
On Tue, 2013-05-28 at 14:43 -0300, Rafael Aquini wrote: > Perhaps the explanation is because we're looking into old stuff bad effects, > then. But just to list a few for your appreciation: > > Apr 23 11:25:31 217-IDC kernel: httpd: page allo

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Eric Dumazet
On Tue, 2013-05-28 at 14:43 -0300, Rafael Aquini wrote: > > Perhaps the explanation is because we're looking into old stuff bad effects, > then. But just to list a few for your appreciation: > > ---

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Rafael Aquini
On Tue, May 28, 2013 at 09:29:37AM -0700, Eric Dumazet wrote: > On Tue, 2013-05-28 at 13:15 -0300, Rafael Aquini wrote: > > > The real problem seems to be that more and more the network stack (drivers, > > perhaps) > > is relying on chunks of contiguous page-blocks without a fallback mechanism >

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Joe Perches
On Tue, 2013-05-28 at 09:00 -0700, Ben Greear wrote: > On 05/27/2013 03:41 PM, Francois Romieu wrote: > > atom...@redhat.com : > > [...] > >> Failed GFP_ATOMIC allocations by the network stack result in dropped > >> packets, which will be received on a subsequent retransmit, and an > >> unnecessar

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Debabrata Banerjee
On Tue, May 28, 2013 at 12:31 AM, Joe Perches wrote: > > I think the __alloc_skb alloc failure message is ok, > but maybe there shouldn't be something "scary" like > a dump_stack. > > Maybe this site should use a trivial debug error > message like below instead. The stack trace may or may not be

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Eric Dumazet
On Tue, 2013-05-28 at 13:15 -0300, Rafael Aquini wrote: > The real problem seems to be that more and more the network stack (drivers, > perhaps) > is relying on chunks of contiguous page-blocks without a fallback mechanism to > order-0 page allocations. When memory gets fragmented, these alloc fa

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Ben Greear
On 05/28/2013 09:15 AM, Rafael Aquini wrote: On Tue, May 28, 2013 at 09:00:45AM -0700, Ben Greear wrote: On 05/27/2013 03:41 PM, Francois Romieu wrote: atom...@redhat.com : [...] Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subseque

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Rafael Aquini
On Tue, May 28, 2013 at 09:00:45AM -0700, Ben Greear wrote: > On 05/27/2013 03:41 PM, Francois Romieu wrote: > >atom...@redhat.com : > >[...] > >>Failed GFP_ATOMIC allocations by the network stack result in dropped > >>packets, which will be received on a subsequent retransmit, and an > >>unnecess

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-28 Thread Ben Greear
On 05/27/2013 03:41 PM, Francois Romieu wrote: atom...@redhat.com : [...] Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a kernel backtrace. These warnings are harmless, but

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Joe Perches
On Mon, 2013-05-27 at 23:04 -0700, Eric Dumazet wrote: > If dump_stack are scary, they are scary for every k[mz]alloc() users, > not only __alloc_skb_alloc() True, but perhaps they are relatively rarer though for non net use cases. -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Eric Dumazet
On Mon, 2013-05-27 at 21:31 -0700, Joe Perches wrote: > I think the __alloc_skb alloc failure message is ok, > but maybe there shouldn't be something "scary" like > a dump_stack. > > Maybe this site should use a trivial debug error > message like below instead. > --- Oh well. If dump_stack are

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Joe Perches
On Mon, 2013-05-27 at 15:25 -0700, Eric Dumazet wrote: > On Mon, 2013-05-27 at 13:39 -0400, Rik van Riel wrote: > > On 05/26/2013 04:19 PM, atom...@redhat.com wrote: > > > Failed GFP_ATOMIC allocations by the network stack result in dropped > > > packets, which will be received on a subsequent retr

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Francois Romieu
atom...@redhat.com : [...] > Failed GFP_ATOMIC allocations by the network stack result in dropped > packets, which will be received on a subsequent retransmit, and an > unnecessary, noisy warning with a kernel backtrace. > > These warnings are harmless, but they still cause users to panic and > f

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Eric Dumazet
On Mon, 2013-05-27 at 13:39 -0400, Rik van Riel wrote: > On 05/26/2013 04:19 PM, atom...@redhat.com wrote: > > From: Aaron Tomlin > > > > Since v1: > > - Removed unnecessary parentheses > > > > ---8<--- > > > > Failed GFP_ATOMIC allocations by the network stack result in dropped > > packets, whi

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Rafael Aquini
On Sun, May 26, 2013 at 09:45:01PM +0100, atom...@redhat.com wrote: > From: Aaron Tomlin > > Since v1: > - Removed unnecessary parentheses (sergei.shtylyov) > > ---8<--- > > Failed GFP_ATOMIC allocations by the network stack result in dropped > packets, which will be received on a subsequent r

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Sergei Shtylyov
Hello. On 27-05-2013 0:19, atom...@redhat.com wrote: From: Aaron Tomlin Since v1: - Removed unnecessary parentheses The "changes since version X" section should typically go after --- tearline, else the mainatiner will have to edit your patch before applying. ---8<--- Failed G

Re: [Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-27 Thread Rik van Riel
On 05/26/2013 04:19 PM, atom...@redhat.com wrote: From: Aaron Tomlin Since v1: - Removed unnecessary parentheses ---8<--- Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a

[Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-26 Thread atomlin
From: Aaron Tomlin Since v1: - Removed unnecessary parentheses (sergei.shtylyov) ---8<--- Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a kernel backtrace. These warnings

[Patch v2] skbuff: Hide GFP_ATOMIC page allocation failures for dropped packets

2013-05-26 Thread atomlin
From: Aaron Tomlin Since v1: - Removed unnecessary parentheses ---8<--- Failed GFP_ATOMIC allocations by the network stack result in dropped packets, which will be received on a subsequent retransmit, and an unnecessary, noisy warning with a kernel backtrace. These warnings are harmless, but