Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread Paul Mackerras
Greg KH writes: > On Tue, Jul 31, 2007 at 06:20:29PM +0200, Andreas Schwab wrote: > > Greg KH <[EMAIL PROTECTED]> writes: > > > > > On Tue, Jul 31, 2007 at 10:46:19PM +0800, WANG Cong wrote: > > >> However, I think using resource_size_t is a bit better than unsigned > > >> long, > > >> so that w

Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread David Miller
From: Christian Borntraeger <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 15:53:28 +0200 > Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]: > > --- a/drivers/pci/rom.c > > +++ b/drivers/pci/rom.c > > @@ -185,7 +185,7 @@ void __iomem *pci_map_rom_copy(struct pc > > IORESOURC

Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread Satyam Sharma
On Tue, 31 Jul 2007, Greg KH wrote: > On Tue, Jul 31, 2007 at 06:20:29PM +0200, Andreas Schwab wrote: > > Greg KH <[EMAIL PROTECTED]> writes: > > > > > On Tue, Jul 31, 2007 at 10:46:19PM +0800, WANG Cong wrote: > > >> However, I think using resource_size_t is a bit better than unsigned > > >>

Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread Greg KH
On Tue, Jul 31, 2007 at 06:20:29PM +0200, Andreas Schwab wrote: > Greg KH <[EMAIL PROTECTED]> writes: > > > On Tue, Jul 31, 2007 at 10:46:19PM +0800, WANG Cong wrote: > >> However, I think using resource_size_t is a bit better than unsigned long, > >> so that we don't need to check the defination

Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread Andreas Schwab
Greg KH <[EMAIL PROTECTED]> writes: > On Tue, Jul 31, 2007 at 10:46:19PM +0800, WANG Cong wrote: >> However, I think using resource_size_t is a bit better than unsigned long, >> so that we don't need to check the defination of it. >> >> - res->start = (unsigned long)kmalloc(*size, GFP_KERNEL); >>

Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread Greg KH
On Tue, Jul 31, 2007 at 10:46:19PM +0800, WANG Cong wrote: > On Tue, Jul 31, 2007 at 08:00:12PM +0530, Satyam Sharma wrote: > > > > > >On Tue, 31 Jul 2007, Christian Borntraeger wrote: > > > >> Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]: > >> > --- a/drivers/pci/rom.c > >> > +++ b/drivers

Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread Satyam Sharma
On Tue, 31 Jul 2007, WANG Cong wrote: > On Tue, Jul 31, 2007 at 08:00:12PM +0530, Satyam Sharma wrote: > > [...] > >It better not be, else we have a bug already anyway. Pointers are 64-bit > >on 64-bit archs. [ it turns out res->start is resource_size_t which is > >set properly as per CONFIG_RES

Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread WANG Cong
On Tue, Jul 31, 2007 at 08:00:12PM +0530, Satyam Sharma wrote: > > >On Tue, 31 Jul 2007, Christian Borntraeger wrote: > >> Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]: >> > --- a/drivers/pci/rom.c >> > +++ b/drivers/pci/rom.c >> > @@ -185,7 +185,7 @@ void __iomem *pci_map_rom_copy(struct p

Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread Satyam Sharma
On Tue, 31 Jul 2007, Christian Borntraeger wrote: > Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]: > > --- a/drivers/pci/rom.c > > +++ b/drivers/pci/rom.c > > @@ -185,7 +185,7 @@ void __iomem *pci_map_rom_copy(struct pc > > IORESOURCE_ROM_BIOS_COPY)) > >

Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread Christian Borntraeger
Am Dienstag, 31. Juli 2007 schrieb [EMAIL PROTECTED]: > --- a/drivers/pci/rom.c > +++ b/drivers/pci/rom.c > @@ -185,7 +185,7 @@ void __iomem *pci_map_rom_copy(struct pc > IORESOURCE_ROM_BIOS_COPY)) > return rom; > > - res->start = (unsigned long)kmalloc(*s

[Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.

2007-07-31 Thread jack
Signed-off-by: Jack Stone <[EMAIL PROTECTED]> CC: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- drivers/pci/rom.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/pci/rom.c === --- a/drivers/pci/rom.c +++ b/dr