Re: [PATH v2] NVMe: init nvme queue before enabling irq

2016-05-12 Thread Johannes Thumshirn
On Wed, May 11, 2016 at 03:16:33PM -0400, Keith Busch wrote: > On Wed, May 11, 2016 at 11:25:16AM +0200, Johannes Thumshirn wrote: > > What ever happened to this patch? > > I can easily reproduce the bug using > > while [ true ]; do rmmod nvme nvme_core; modprobe nvme; done > > This patch was supp

Re: [PATH v2] NVMe: init nvme queue before enabling irq

2016-05-12 Thread Johannes Thumshirn
On Wed, May 11, 2016 at 03:16:33PM -0400, Keith Busch wrote: > On Wed, May 11, 2016 at 11:25:16AM +0200, Johannes Thumshirn wrote: > > What ever happened to this patch? > > I can easily reproduce the bug using > > while [ true ]; do rmmod nvme nvme_core; modprobe nvme; done > > This patch was supp

Re: [PATH v2] NVMe: init nvme queue before enabling irq

2016-05-11 Thread Keith Busch
On Wed, May 11, 2016 at 11:25:16AM +0200, Johannes Thumshirn wrote: > What ever happened to this patch? > I can easily reproduce the bug using > while [ true ]; do rmmod nvme nvme_core; modprobe nvme; done This patch was supposed to fix using a doorbell between resets when the driver had BAR0 unma

Re: [PATH v2] NVMe: init nvme queue before enabling irq

2016-05-11 Thread Johannes Thumshirn
On 2016-01-20 11:48, Wenbo Wang wrote: From: Wenbo Wang During reset process, the nvme_dev->bar (ioremapped) may change, so nvmeq->q_db shall be also updated by nvme_init_queue(). Currently nvmeq irq is enabled before queue init, so a spurious interrupt triggered nvme_process_cq may access nvm

Re: [PATH v2] NVMe: init nvme queue before enabling irq

2016-05-10 Thread Johannes Thumshirn
On Wed, Jan 20, 2016 at 10:17:10AM -0700, Jens Axboe wrote: > On 01/20/2016 10:12 AM, Greg KH wrote: > > On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: > > > From: Wenbo Wang > > > > > > During reset process, the nvme_dev->bar (ioremapped) may change, > > > so nvmeq->q_db shall be al

Re: [PATH v2] NVMe: init nvme queue before enabling irq

2016-04-25 Thread Johannes Thumshirn
On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: > From: Wenbo Wang > > During reset process, the nvme_dev->bar (ioremapped) may change, > so nvmeq->q_db shall be also updated by nvme_init_queue(). > > Currently nvmeq irq is enabled before queue init, so a spurious > interrupt trigger

Re: [PATH v2] NVMe: init nvme queue before enabling irq

2016-01-20 Thread Jens Axboe
On 01/20/2016 10:12 AM, Greg KH wrote: On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: From: Wenbo Wang During reset process, the nvme_dev->bar (ioremapped) may change, so nvmeq->q_db shall be also updated by nvme_init_queue(). Currently nvmeq irq is enabled before queue init, so

Re: [PATH v2] NVMe: init nvme queue before enabling irq

2016-01-20 Thread Greg KH
On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: > From: Wenbo Wang > > During reset process, the nvme_dev->bar (ioremapped) may change, > so nvmeq->q_db shall be also updated by nvme_init_queue(). > > Currently nvmeq irq is enabled before queue init, so a spurious > interrupt trigger

Re: [PATH v2] NVMe: init nvme queue before enabling irq

2016-01-20 Thread Johannes Thumshirn
On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: > From: Wenbo Wang > > During reset process, the nvme_dev->bar (ioremapped) may change, > so nvmeq->q_db shall be also updated by nvme_init_queue(). > > Currently nvmeq irq is enabled before queue init, so a spurious > interrupt trigger

Re: [PATH v2] NVMe: init nvme queue before enabling irq

2016-01-20 Thread Keith Busch
On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: > From: Wenbo Wang > > During reset process, the nvme_dev->bar (ioremapped) may change, > so nvmeq->q_db shall be also updated by nvme_init_queue(). > > Currently nvmeq irq is enabled before queue init, so a spurious > interrupt trigger