Re: [PATCHv5] perf tools: enable close-on-exec flag on perf file descriptor

2014-06-03 Thread Jiri Olsa
On Tue, Jun 03, 2014 at 10:57:15AM +0200, Yann Droneaud wrote: > Le lundi 02 juin 2014 à 21:23 +0200, Jiri Olsa a écrit : > > On Mon, Jun 02, 2014 at 12:56:34PM +0200, Yann Droneaud wrote: > > > > SNIP > > > > > > > > Hi, > > > > > > Quite the same patch from v4. I'm interested in some > > > fe

Re: [PATCHv5] perf tools: enable close-on-exec flag on perf file descriptor

2014-06-03 Thread Adrian Hunter
On 06/03/2014 11:57 AM, Yann Droneaud wrote: > Nice catch. This function was introduced by commit > c09ec622629eeb4b7877646a42852e7156363425 ('perf evlist: Add > can_select_event() method') by Adrian Hunter > and it seems it was never used by perf tools. It is part of preparation for Intel PT.

Re: [PATCHv5] perf tools: enable close-on-exec flag on perf file descriptor

2014-06-03 Thread Yann Droneaud
Le lundi 02 juin 2014 à 21:23 +0200, Jiri Olsa a écrit : > On Mon, Jun 02, 2014 at 12:56:34PM +0200, Yann Droneaud wrote: > > SNIP > > > > > Hi, > > > > Quite the same patch from v4. I'm interested in some > > feedback so that I could improve the patch if needed. > > > > Regards. > > > > Chan

Re: [PATCHv5] perf tools: enable close-on-exec flag on perf file descriptor

2014-06-02 Thread Jiri Olsa
On Mon, Jun 02, 2014 at 12:56:34PM +0200, Yann Droneaud wrote: SNIP > > Hi, > > Quite the same patch from v4. I'm interested in some > feedback so that I could improve the patch if needed. > > Regards. > > Changes from v4 [1]: > - rebase on next-20140530 and update commit message. hi, I wasn

[PATCHv5] perf tools: enable close-on-exec flag on perf file descriptor

2014-06-02 Thread Yann Droneaud
In commit a21b0b354d4a ('perf: Introduce a flag to enable close-on-exec in perf_event_open()'), flag PERF_FLAG_FD_CLOEXEC was added to perf_event_open(2) syscall to allows userspace to atomically enable close-on-exec behavor when creating the file descriptor. This patch makes perf tools use the ne