Re: [PATCHv5,RESEND 1/8] gpu: host1x: Add host1x driver

2013-02-06 Thread Terje Bergström
On 04.02.2013 23:43, Thierry Reding wrote: > My point was that you could include the call to host1x_syncpt_reset() > within host1x_syncpt_init(). That will keep unneeded code out of the > host1x_probe() function. Also you don't want to use the syncpoints > uninitialized, right? Of course, sorry, I

Re: [PATCHv5,RESEND 1/8] gpu: host1x: Add host1x driver

2013-02-04 Thread Thierry Reding
On Mon, Feb 04, 2013 at 07:30:08PM -0800, Terje Bergström wrote: > On 04.02.2013 01:09, Thierry Reding wrote: > > On Tue, Jan 15, 2013 at 01:43:57PM +0200, Terje Bergstrom wrote: > >> Add host1x, the driver for host1x and its client unit 2D. > > > > Maybe this could be a bit more verbose. Perhaps

Re: [PATCHv5,RESEND 1/8] gpu: host1x: Add host1x driver

2013-02-04 Thread Terje Bergström
On 04.02.2013 01:09, Thierry Reding wrote: > On Tue, Jan 15, 2013 at 01:43:57PM +0200, Terje Bergstrom wrote: >> Add host1x, the driver for host1x and its client unit 2D. > > Maybe this could be a bit more verbose. Perhaps describe what host1x is. Sure. I could just steal the paragraph from Steph

Re: [PATCHv5,RESEND 1/8] gpu: host1x: Add host1x driver

2013-02-04 Thread Thierry Reding
On Tue, Jan 15, 2013 at 01:43:57PM +0200, Terje Bergstrom wrote: > Add host1x, the driver for host1x and its client unit 2D. Maybe this could be a bit more verbose. Perhaps describe what host1x is. > diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig [...] > @@ -0,0 +1,6 @@ > +c

[PATCHv5,RESEND 1/8] gpu: host1x: Add host1x driver

2013-01-15 Thread Terje Bergstrom
Add host1x, the driver for host1x and its client unit 2D. Signed-off-by: Terje Bergstrom --- drivers/gpu/Makefile |1 + drivers/gpu/host1x/Kconfig|6 + drivers/gpu/host1x/Makefile |8 ++ drivers/gpu/host1x/dev.c | 1