Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-14 Thread Matt Porter
On Thu, Nov 14, 2013 at 05:23:08PM +0100, Tomasz Figa wrote: > On Thursday 14 of November 2013 17:14:31 Florian Meier wrote: > > >> >> I am becoming desperate anyway that this migration will ever fully > > >> >> take place > > >> > > > >> > Why not? It's just a matter of people like you working

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-14 Thread Florian Meier
2013/11/14 Tomasz Figa : > On Thursday 14 of November 2013 17:14:31 Florian Meier wrote: >> >> >> I am becoming desperate anyway that this migration will ever fully >> >> >> take place >> >> > >> >> > Why not? It's just a matter of people like you working on this (and >> >> > addressing some re

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-14 Thread Tomasz Figa
On Thursday 14 of November 2013 17:14:31 Florian Meier wrote: > >> >> I am becoming desperate anyway that this migration will ever fully > >> >> take place > >> > > >> > Why not? It's just a matter of people like you working on this (and > >> > addressing some review comments ;)). > >> > >> The

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-14 Thread Florian Meier
> I mean, something closer to: > . Ok :-) >> >> I am becoming desperate anyway that this migration will ever fully >> >> take place >> > >> > Why not? It's just a matter of people like you working on this (and >> > addressing some review comments ;)). >> >> The most common comment about t

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-14 Thread Tomasz Figa
On Thursday 14 of November 2013 16:41:56 Florian Meier wrote: > 2013/11/14 Tomasz Figa : > > On Thursday 14 of November 2013 15:44:05 Florian Meier wrote: > >> 2013/11/14 Tomasz Figa : > >> > On Thursday 14 of November 2013 08:12:46 Florian Meier wrote: > >> >> On 13.11.2013 21:39, Tomasz Figa wrot

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-14 Thread Florian Meier
2013/11/14 Tomasz Figa : > On Thursday 14 of November 2013 15:44:05 Florian Meier wrote: >> 2013/11/14 Tomasz Figa : >> > On Thursday 14 of November 2013 08:12:46 Florian Meier wrote: >> >> On 13.11.2013 21:39, Tomasz Figa wrote: >> >> > On Wednesday 13 of November 2013 20:35:22 Florian Meier wrote

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-14 Thread Tomasz Figa
On Thursday 14 of November 2013 15:44:05 Florian Meier wrote: > 2013/11/14 Tomasz Figa : > > On Thursday 14 of November 2013 08:12:46 Florian Meier wrote: > >> On 13.11.2013 21:39, Tomasz Figa wrote: > >> > On Wednesday 13 of November 2013 20:35:22 Florian Meier wrote: > >> +- brcm,dma-channel

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-14 Thread Florian Meier
2013/11/14 Tomasz Figa : > On Thursday 14 of November 2013 08:12:46 Florian Meier wrote: >> On 13.11.2013 21:39, Tomasz Figa wrote: >> > On Wednesday 13 of November 2013 20:35:22 Florian Meier wrote: >> +- brcm,dma-channel-mask: Bit mask representing the channels available. >> >>> >> >>> What

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-14 Thread Tomasz Figa
On Thursday 14 of November 2013 08:12:46 Florian Meier wrote: > On 13.11.2013 21:39, Tomasz Figa wrote: > > On Wednesday 13 of November 2013 20:35:22 Florian Meier wrote: > >> On 13.11.2013 19:43, Tomasz Figa wrote: > > diff --git a/Documentation/devicetree/bindings/dma/bcm2835-dma.t

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-13 Thread Florian Meier
On 13.11.2013 21:39, Tomasz Figa wrote: > On Wednesday 13 of November 2013 20:35:22 Florian Meier wrote: >> On 13.11.2013 19:43, Tomasz Figa wrote: diff --git a/Documentation/devicetree/bindings/dma/bcm2835-dma.txt b/Documentation/devicetree/bindings/dma/bcm2835-dma.txt ne

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-13 Thread Tomasz Figa
On Wednesday 13 of November 2013 20:35:22 Florian Meier wrote: > On 13.11.2013 19:43, Tomasz Figa wrote: > > Hi Florian, > > > > Seems like I accidentally replied to some old version of this patch. > > Not sure how many of those comments were still relevant for V3, but > > let me look at this vers

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-13 Thread Florian Meier
On 13.11.2013 19:43, Tomasz Figa wrote: > Hi Florian, > > Seems like I accidentally replied to some old version of this patch. > Not sure how many of those comments were still relevant for V3, but > let me look at this version and see whether we can still improve things > a bit. Please see my comm

Re: [PATCHv4] dmaengine: Add support for BCM2835

2013-11-13 Thread Tomasz Figa
Hi Florian, Seems like I accidentally replied to some old version of this patch. Not sure how many of those comments were still relevant for V3, but let me look at this version and see whether we can still improve things a bit. Please see my comments inline. On Wednesday 13 of November 2013 18:53

[PATCHv4] dmaengine: Add support for BCM2835

2013-11-13 Thread Florian Meier
Add support for DMA controller of BCM2835 as used in the Raspberry Pi. Currently it only supports cyclic DMA. Signed-off-by: Florian Meier --- Besides of many minor improvements (thanks to your helpful comments), this fourth version does the assignment of the virtual to the hardware channel alre