Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-12 Thread Thor Thayer
On Fri, May 9, 2014 at 3:52 PM, Borislav Petkov wrote: > On Fri, May 09, 2014 at 03:31:53PM -0500, Thor Thayer wrote: >> Yes, good point. Our hardware can't recover from Double Bit Errors so >> I'll go back to the panic() in that path. I like the flexibility of >> the command line parameter though

Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-09 Thread Borislav Petkov
On Fri, May 09, 2014 at 03:31:53PM -0500, Thor Thayer wrote: > Yes, good point. Our hardware can't recover from Double Bit Errors so > I'll go back to the panic() in that path. I like the flexibility of > the command line parameter though... Like to panic by default when the machine is booted norm

Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-09 Thread Thor Thayer
On Fri, May 9, 2014 at 8:52 AM, Borislav Petkov wrote: > On Thu, May 08, 2014 at 03:37:19PM -0500, Thor Thayer wrote: >> Yes. Their reasoning is that they want to retain the rights and >> warranty language with the file (just in case the COPYING file >> changes). > > Ok, thanks for checking up on

Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-09 Thread Thor Thayer
On Thu, May 8, 2014 at 5:44 PM, Dinh Nguyen wrote: > > On 5/5/14 5:52 PM, ttha...@altera.com wrote: >> From: Thor Thayer >> >> --- >> v2: Use the SDRAM controller registers to calculate memory size >> instead of the Device Tree. Update To & Cc list. Add maintainer >> information. >> +

Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-09 Thread Borislav Petkov
On Thu, May 08, 2014 at 03:37:19PM -0500, Thor Thayer wrote: > Yes. Their reasoning is that they want to retain the rights and > warranty language with the file (just in case the COPYING file > changes). Ok, thanks for checking up on this. > Yes. I tested using edac_core.edac_mc_panic_on_ue=1 fro

Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-08 Thread Dinh Nguyen
On 5/5/14 5:52 PM, ttha...@altera.com wrote: > From: Thor Thayer > > --- > v2: Use the SDRAM controller registers to calculate memory size > instead of the Device Tree. Update To & Cc list. Add maintainer > information. > > v3: EDAC driver cleanup based on comments from Mailing list. > >

Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-08 Thread Thor Thayer
On Thu, May 8, 2014 at 7:05 AM, Borislav Petkov wrote: > On Mon, May 05, 2014 at 05:52:17PM -0500, ttha...@altera.com wrote: >> From: Thor Thayer > > Missing commit message. Whoops. I don't know what happened there. I'll fix it. > >> --- >> v2: Use the SDRAM controller registers to calculate me

Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-08 Thread Borislav Petkov
On Mon, May 05, 2014 at 05:52:17PM -0500, ttha...@altera.com wrote: > From: Thor Thayer Missing commit message. > --- > v2: Use the SDRAM controller registers to calculate memory size > instead of the Device Tree. Update To & Cc list. Add maintainer > information. > > v3: EDAC driver cl

Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-06 Thread Thor Thayer
On Tue, May 6, 2014 at 10:42 AM, Dinh Nguyen wrote: > On Mon, 2014-05-05 at 17:52 -0500, Thor Thayer wrote: >> From: Thor Thayer >> >> --- >> v2: Use the SDRAM controller registers to calculate memory size >> instead of the Device Tree. Update To & Cc list. Add maintainer >> information.

Re: [PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-06 Thread Dinh Nguyen
On Mon, 2014-05-05 at 17:52 -0500, Thor Thayer wrote: > From: Thor Thayer > > --- > v2: Use the SDRAM controller registers to calculate memory size > instead of the Device Tree. Update To & Cc list. Add maintainer > information. > > v3: EDAC driver cleanup based on comments from Mailing

[PATCHv3 3/3] edac: altera: Add EDAC support for Altera SDRAM

2014-05-05 Thread tthayer
From: Thor Thayer --- v2: Use the SDRAM controller registers to calculate memory size instead of the Device Tree. Update To & Cc list. Add maintainer information. v3: EDAC driver cleanup based on comments from Mailing list. Signed-off-by: Thor Thayer --- MAINTAINERS|