Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-11 Thread Sourav Poddar
On Monday 08 July 2013 08:02 PM, Felipe Balbi wrote: Hi, On Mon, Jul 08, 2013 at 07:12:59PM +0530, Sourav Poddar wrote: +static inline unsigned long dra7xxx_readl(struct dra7xxx_qspi *qspi, + unsigned long reg) +{ + return readl(qspi->base + reg); +} + +static inline void dr

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-09 Thread Nishanth Menon
On 15:40-20130709, Mark Brown wrote: > On Tue, Jul 09, 2013 at 07:50:55AM -0500, Nishanth Menon wrote: > > > with this input and looking closer, I think I see what you are saying now: > > dra7xxx_qspi_prepare_xfer -> does a pm_runtime_get_sync > > dra7xxx_qspi_unprepare_xfer -> does a pm_runtime_m

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 07:50:55AM -0500, Nishanth Menon wrote: > with this input and looking closer, I think I see what you are saying now: > dra7xxx_qspi_prepare_xfer -> does a pm_runtime_get_sync > dra7xxx_qspi_unprepare_xfer -> does a pm_runtime_mark_last_busy, > pm_runtime_put_autosuspend >

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-09 Thread Nishanth Menon
On 07/09/2013 01:51 AM, Felipe Balbi wrote: On Mon, Jul 08, 2013 at 03:33:30PM -0500, Nishanth Menon wrote: +static int dra7xxx_qspi_start_transfer_one(struct spi_master *master, + struct spi_message *m) +{ + struct dra7xxx_qspi *qspi = spi_master_get_devdata(master); +

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-09 Thread Nishanth Menon
On 07/09/2013 05:05 AM, Mark Brown wrote: On Tue, Jul 09, 2013 at 09:51:43AM +0300, Felipe Balbi wrote: Looks like a case to use regmap? Dumb q: why cant we use regmap_spi? worst case, you should be able to read regmap-spi and you'll see why it can't be used in this case. regmap-spi is fo

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-09 Thread Mark Brown
On Tue, Jul 09, 2013 at 09:51:43AM +0300, Felipe Balbi wrote: > > Looks like a case to use regmap? > > Dumb q: why cant we use regmap_spi? worst case, you should be able to > read regmap-spi and you'll see why it can't be used in this case. > regmap-spi is for SPI clients who want to read their

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-09 Thread Sourav Poddar
On Monday 08 July 2013 08:02 PM, Felipe Balbi wrote: Hi, On Mon, Jul 08, 2013 at 07:12:59PM +0530, Sourav Poddar wrote: +static inline unsigned long dra7xxx_readl(struct dra7xxx_qspi *qspi, + unsigned long reg) +{ + return readl(qspi->base + reg); +} + +static inline void dr

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-09 Thread Sourav Poddar
On Tuesday 09 July 2013 02:03 AM, Nishanth Menon wrote: On 19:12-20130708, Sourav Poddar wrote: [..] generic comment, given our historical mistakes of making drivers specific to a SoC family, it never is. Now, ti-qspi in file name is a step in the right direction, but, rest of the code(function

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-08 Thread Felipe Balbi
Hi, On Mon, Jul 08, 2013 at 03:33:30PM -0500, Nishanth Menon wrote: > > +static inline unsigned long dra7xxx_readl_data(struct dra7xxx_qspi *qspi, > > + unsigned long reg, int wlen) > > +{ > > + switch (wlen) { > > + case 8: > > + return readw(qspi->base + reg); > > +

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-08 Thread Nishanth Menon
On 19:12-20130708, Sourav Poddar wrote: [..] generic comment, given our historical mistakes of making drivers specific to a SoC family, it never is. Now, ti-qspi in file name is a step in the right direction, but, rest of the code(function names etc) is just married to DRA7 family of processor, wh

Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-08 Thread Felipe Balbi
Hi, On Mon, Jul 08, 2013 at 07:12:59PM +0530, Sourav Poddar wrote: > +static inline unsigned long dra7xxx_readl(struct dra7xxx_qspi *qspi, > + unsigned long reg) > +{ > + return readl(qspi->base + reg); > +} > + > +static inline void dra7xxx_writel(struct dra7xxx_qspi *qspi, > +

[PATCHv3 2/3] drivers: spi: Add qspi flash controller

2013-07-08 Thread Sourav Poddar
The patch add basic support for the quad spi controller. QSPI is a kind of spi module that allows single, dual and quad read access to external spi devices. The module has a memory mapped interface which provide direct interface for accessing data form external spi devices. The patch will configu