Re: [PATCHv3 1/4] modem_shm: Add Modem Access Framework

2012-08-26 Thread Greg KH
On Mon, Aug 27, 2012 at 11:19:26AM +0530, Arun Murthy wrote: > +struct modem { > + struct device *dev; No, this needs to be: struct device dev; Please fix it up to be like that, otherwise you are not using the driver model properly at all. > +/** > + * modem_register - register a mod

[PATCHv3 1/4] modem_shm: Add Modem Access Framework

2012-08-26 Thread Arun Murthy
Adds Modem Access Framework, which allows for registering platform specific modem access mechanisms. The framework also exposes APIs for client drivers for getting and releasing access to modem, regardless of the underlying platform specific access mechanism. Signed-off-by: Arun Murthy --- drive