Re: [PATCHv3]Checks for Null value in function *get_skub

2014-06-16 Thread Steve Wise
On 6/16/2014 10:14 AM, Nick Krause wrote: >From what I know yes so I would close the bug at the the link in my previous email and just void my patch. Cheers Nick We shouldn't be kfree-ing an skb anyway. Should use kfree_skb(). There is still a leak if skb is non-null and the skb is non linea

Re: [PATCHv3]Checks for Null value in function *get_skub

2014-06-16 Thread Nick Krause
>From what I know yes so I would close the bug at the the link in my previous email and just void my patch. Cheers Nick On Mon, Jun 16, 2014 at 11:12 AM, Levente Kurusa wrote: > On 06/16/2014 05:08 PM, Nicholas Krause wrote: >> >> Signed-off-by: Nicholas Krause >> --- >> drivers/infiniband/hw/

Re: [PATCHv3]Checks for Null value in function *get_skub

2014-06-16 Thread Levente Kurusa
On 06/16/2014 05:08 PM, Nicholas Krause wrote: Signed-off-by: Nicholas Krause --- drivers/infiniband/hw/cxgb4/cm.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index f9477e2..2d56983 100644 ---

Re: [PATCHv3]Checks for Null value in function *get_skub

2014-06-16 Thread Nick Krause
The bug is open here https://bugzilla.kernel.org/show_bug.cgi?id=44631. I would recommend closing it now as I seem to have fixed it. Cheers Nick On Mon, Jun 16, 2014 at 11:08 AM, Nicholas Krause wrote: > Signed-off-by: Nicholas Krause > --- > drivers/infiniband/hw/cxgb4/cm.c | 8 +++- > 1 f

[PATCHv3]Checks for Null value in function *get_skub

2014-06-16 Thread Nicholas Krause
Signed-off-by: Nicholas Krause --- drivers/infiniband/hw/cxgb4/cm.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index f9477e2..2d56983 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/in