Re: [PATCHv3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-27 Thread David Herrmann
Hi On Thu, Feb 27, 2014 at 12:16 PM, Kay Sievers wrote: > On Tue, Feb 25, 2014 at 10:38 AM, David Herrmann > wrote: >> On Tue, Feb 25, 2014 at 8:51 AM, Hannes Reinecke wrote: > >>> Positive? >>> I thought this was precisely the problem, ->device() changing the >>> index '0' into something non-

Re: [PATCHv3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-27 Thread Kay Sievers
On Tue, Feb 25, 2014 at 10:38 AM, David Herrmann wrote: > On Tue, Feb 25, 2014 at 8:51 AM, Hannes Reinecke wrote: >> Positive? >> I thought this was precisely the problem, ->device() changing the >> index '0' into something non-zero. >> The reports we had were that the line 'tty0' changed into '

Re: [PATCHv3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-25 Thread David Herrmann
Hi On Tue, Feb 25, 2014 at 8:51 AM, Hannes Reinecke wrote: > On 02/24/2014 03:58 PM, David Herrmann wrote: >> Hi >> >> On Mon, Feb 24, 2014 at 3:50 PM, Hannes Reinecke wrote: >>> The 'active' sysfs attribute should refer to the currently >>> active tty devices the console is running on, not the

Re: [PATCHv3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-24 Thread Hannes Reinecke
On 02/24/2014 03:58 PM, David Herrmann wrote: > Hi > > On Mon, Feb 24, 2014 at 3:50 PM, Hannes Reinecke wrote: >> The 'active' sysfs attribute should refer to the currently >> active tty devices the console is running on, not the currently >> active console. >> The console structure doesn't refer

Re: [PATCHv3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-24 Thread David Herrmann
Hi On Mon, Feb 24, 2014 at 3:50 PM, Hannes Reinecke wrote: > The 'active' sysfs attribute should refer to the currently > active tty devices the console is running on, not the currently > active console. > The console structure doesn't refer to any device in sysfs, > only the tty the console is r

[PATCHv3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-24 Thread Hannes Reinecke
The 'active' sysfs attribute should refer to the currently active tty devices the console is running on, not the currently active console. The console structure doesn't refer to any device in sysfs, only the tty the console is running on has. So we need to print out the tty names in 'active', not t

[PATCHv3] tty: Set correct tty name in 'active' sysfs attribute

2014-02-07 Thread Hannes Reinecke
The 'active' sysfs attribute should refer to the currently active tty devices the console is running on, not the currently active console. The console structure doesn't refer to any device in sysfs, only the tty the console is running on has. So we need to print out the tty names in 'active', not t